Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compute_instance_helpers.go.erb to the list of compiled files #4198

Merged
merged 1 commit into from
Nov 6, 2020
Merged

add compute_instance_helpers.go.erb to the list of compiled files #4198

merged 1 commit into from
Nov 6, 2020

Conversation

daniel-cit
Copy link
Contributor

@daniel-cit daniel-cit commented Nov 6, 2020

Add the file compute_instance_helpers.go.erb to the list of files that need to be compiled before been copied to downstream terraform-google-conversion repo.

Related to GoogleCloudPlatform/terraform-google-conversion#572

Release Note Template for Downstream PRs (will be copied)

Compile erb template before copy of compute_instance_helpers.go file

@google-cla google-cla bot added the cla: yes label Nov 6, 2020
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ndmckinley, please review this PR or find an appropriate assignee.

@nat-henderson
Copy link
Contributor

I'll wait for the generator to finish then merge. :)

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

TF Conversion: Diff ( 1 file changed, 1 insertion(+), 41 deletions(-))

@modular-magician
Copy link
Collaborator

Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:

```release-note:TYPE
Release note
```

@nat-henderson
Copy link
Contributor

Cool, I see you edited it, I'll rerun. /gcbrun

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=156435"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

TF Conversion: Diff ( 1 file changed, 1 insertion(+), 41 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceSpannerInstance_basic|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccBigqueryDataTransferConfig|TestAccComposerEnvironment_withUpdateOnCreate|TestAccFilestoreInstance_filestoreInstanceBasicExample|TestAccFilestoreInstance_update|TestAccOSLoginSSHPublicKey_osLoginSshKeyExpiry You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=156451"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants