-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove MaxItems validation check on Bigtable instance cluster count #4166
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @ScottSuarez, please review this PR or find an appropriate assignee. |
I agree that the documentation could get out dated if the api increases their supported count. Based on the documentation there hasn't been an increase as of yet. Any reason for this change? Philosophy? |
Was tagged in on an email giving more context. I understand the scenario and will upstream this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm :)
/gcbrun |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=155704" |
/gcbrun |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=155760" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceIAMBetaWorkloadIdentityPool_basic|TestAccDataSourceSpannerInstance_basic|TestAccBigqueryDataTransferConfig|TestAccResourceGoogleProjectDefaultServiceAccountsBasic|TestAccResourceGoogleProjectDefaultServiceAccountsDisable|TestAccResourceGoogleProjectDefaultServiceAccountsDelete|TestAccResourceGoogleProjectDefaultServiceAccountsDeprivilege|TestAccIAMBetaWorkloadIdentityPoolProvider_iamWorkloadIdentityPoolProviderAwsBasicExample|TestAccIAMBetaWorkloadIdentityPoolProvider_iamWorkloadIdentityPoolProviderAwsFullExample|TestAccIAMBetaWorkloadIdentityPoolProvider_iamWorkloadIdentityPoolProviderOidcBasicExample|TestAccIAMBetaWorkloadIdentityPoolProvider_iamWorkloadIdentityPoolProviderOidcFullExample|TestAccIAMBetaWorkloadIdentityPoolProvider_aws|TestAccIAMBetaWorkloadIdentityPoolProvider_oidc|TestAccOSLoginSSHPublicKey_osLoginSshKeyBasicExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=155789" |
Remove MaxItems validation check on Bigtable instance cluster count. Allow the API to return an error on invalid configuration, rather than maintaining second source of truth here.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)