-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't run sql precheck if projects.get call fails #4141
Don't run sql precheck if projects.get call fails #4141
Conversation
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=153657" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceSpannerInstance_basic You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=153741" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few comments surrounding readability
third_party/terraform/resources/resource_sql_database_instance.go.erb
Outdated
Show resolved
Hide resolved
third_party/terraform/resources/resource_sql_database_instance.go.erb
Outdated
Show resolved
Hide resolved
third_party/terraform/resources/resource_sql_database_instance.go.erb
Outdated
Show resolved
Hide resolved
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=153832" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=153832" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=153842" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceSpannerInstance_basic You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=153869" |
Fixes hashicorp/terraform-provider-google#7595
Reproduced locally, and this fixes the error the user experienced. This requires a whole bunch of host project / service project IAM setup that doesn't make it worth setting up an integration test for imo.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)