-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Build Enviroment Vars to Cloud Functions #4133
Conversation
Fork Update
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @c2thorn, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 39 insertions(+), 9 deletions(-)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 4 files changed, 82 insertions(+), 42 deletions(-)) |
/gcbrun |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=153423" |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 4 files changed, 82 insertions(+), 42 deletions(-)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceSpannerInstance_basic|TestAccCloudFunctionsFunction_update|TestAccCloudFunctionsFunction_basic|TestAccCloudFunctionsFunction_pubsub|TestAccCloudFunctionsFunction_bucket|TestAccCloudFunctionsFunction_sourceRepo|TestAccCloudFunctionsFunction_firestore|TestAccCloudFunctionsFunction_serviceAccountEmail|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeRegionPerInstanceConfig_update|TestAccComputeResourcePolicy_attached|TestAccComputeRoute_hopInstance|TestAccComputeTargetPool_basic|TestAccComputeTargetPool_update|TestAccContainerCluster_withNodeConfigShieldedInstanceConfig|TestAccDataCatalogPolicyTag_dataCatalogTaxonomiesPolicyTagChildPoliciesExample|TestAccDataprocClusterIamBinding|TestAccDataprocClusterIamMember|TestAccDataprocClusterIamPolicy|TestAccDataprocCluster_updatable|TestAccDataprocCluster_withStagingBucket|TestAccDataprocCluster_withInitAction|TestAccDataprocCluster_withServiceAcc|TestAccDataprocJobIamBinding|TestAccDataprocJobIamMember|TestAccDataprocJob_updatable|TestAccDataprocJob_PySpark|TestAccDataprocJobIamPolicy|TestAccDataprocJob_Spark|TestAccDataprocJob_Hadoop|TestAccDataprocJob_Hive|TestAccDataprocJob_SparkSql|TestAccDataprocJob_Pig|TestAccNetworkManagementConnectivityTest_update|TestAccNotebooksInstance_create_container|TestAccNotebooksInstance_update|TestAccNotebooksInstance_create_vm_image You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=153424" |
Fixes: hashicorp/terraform-provider-google#7589
Also, I bumped nodejs to 10 as 8 can't be created any more.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)