Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data source for pubsub topics #4062

Conversation

ScottSuarez
Copy link
Contributor

@ScottSuarez ScottSuarez commented Oct 6, 2020

Upstreaming pr to add data source for pubsub topics: PR 7426

Resolves 6800

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_pubsub_topic`

@google-cla google-cla bot added the cla: yes label Oct 6, 2020
@ScottSuarez ScottSuarez requested a review from danawillow October 6, 2020 20:40
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 154 insertions(+))
Terraform Beta: Diff ( 5 files changed, 154 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=150820"

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you use the upstreaming script? I'm surprised not to see the original author listed as a co-committer on this.

Also, take another look at the release notes guide: https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md#examples

third_party/terraform/utils/provider.go.erb Show resolved Hide resolved
@ScottSuarez
Copy link
Contributor Author

Did you use the upstreaming script? I'm surprised not to see the original author listed as a co-committer on this.

Also, take another look at the release notes guide: https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md#examples

I tried to use the upstreaming script initially but ran into some conflicts even after removing the navigationbar commit. So I switched to manually copy the files for now. I'll try and troubleshoot a little later and possibly add a section to the documentation on resolving these sorts of conflicts if I come to solutions.

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGooglePubsubTopic_basic|TestAccDataSourceGooglePubsubTopic_optionalProject|TestAccProviderMeta_setModuleName|TestAccComputeSnapshot_encryptionCMEK|TestAccMonitoringDashboard_basic|TestAccMonitoringDashboard_gridLayout|TestAccMonitoringDashboard_rowLayout|TestAccMonitoringDashboard_update You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=150832"

@danawillow
Copy link
Contributor

Did you use the upstreaming script? I'm surprised not to see the original author listed as a co-committer on this.
Also, take another look at the release notes guide: https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md#examples

I tried to use the upstreaming script initially but ran into some conflicts even after removing the navigationbar commit. So I switched to manually copy the files for now. I'll try and troubleshoot a little later and possibly add a section to the documentation on resolving these sorts of conflicts if I come to solutions.

Cool, when I run into those issues I often just update the commit to include the other author so they can still get the credit.

@google-cla
Copy link

google-cla bot commented Oct 6, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Oct 6, 2020
Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also I fixed the release note

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 154 insertions(+))
Terraform Beta: Diff ( 5 files changed, 154 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=150833"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccProviderMeta_setModuleName|TestAccComputeSnapshot_encryptionCMEK|TestAccMonitoringDashboard_gridLayout|TestAccMonitoringDashboard_basic|TestAccMonitoringDashboard_rowLayout|TestAccMonitoringDashboard_update You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=150836"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add data source for pubsub topics
4 participants