-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data source for pubsub topics #4062
Add data source for pubsub topics #4062
Conversation
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=150820" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you use the upstreaming script? I'm surprised not to see the original author listed as a co-committer on this.
Also, take another look at the release notes guide: https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md#examples
I tried to use the upstreaming script initially but ran into some conflicts even after removing the navigationbar commit. So I switched to manually copy the files for now. I'll try and troubleshoot a little later and possibly add a section to the documentation on resolving these sorts of conflicts if I come to solutions. |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGooglePubsubTopic_basic|TestAccDataSourceGooglePubsubTopic_optionalProject|TestAccProviderMeta_setModuleName|TestAccComputeSnapshot_encryptionCMEK|TestAccMonitoringDashboard_basic|TestAccMonitoringDashboard_gridLayout|TestAccMonitoringDashboard_rowLayout|TestAccMonitoringDashboard_update You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=150832" |
Cool, when I run into those issues I often just update the commit to include the other author so they can still get the credit. |
…tSuarez/magic-modules into pubsub_topic_add_datasource
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, also I fixed the release note
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=150833" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccProviderMeta_setModuleName|TestAccComputeSnapshot_encryptionCMEK|TestAccMonitoringDashboard_gridLayout|TestAccMonitoringDashboard_basic|TestAccMonitoringDashboard_rowLayout|TestAccMonitoringDashboard_update You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=150836" |
Upstreaming pr to add data source for pubsub topics: PR 7426
Resolves 6800
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)