separate code generation and docs generation #4061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compiler.rb
Outdated
| @@ -86,6 +88,12 @@ | |||
| opt.on('-d', '--debug', 'Show all debug logs') do |_debug| | |||
| Google::LOGGER.level = Logger::DEBUG | |||
| end | |||
| opt.on('-c', '--code', 'Generate code only') do | |||
There was a problem hiding this comment.
Would you consider doing this in the opposite direction? default to true, with flags for "--no-code" and "--no-docs"? I know it's a nitpick but that feels more consistent to me and more readable in scripts. Generally speaking a --flag adds behavior unless it starts with --no.
There was a problem hiding this comment.
@ndmckinley - i think i made the change you were looking for, let me know if i misinterpreted. thanks!!
nat-henderson
approved these changes
Oct 7, 2020
5 tasks
wata727
added a commit
to terraform-linters/magic-modules
that referenced
this pull request
Oct 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hashicorp/terraform-provider-google#7374
This PR allows separation of code generation and docs generation when needed. This will allow us to generate ga-code for TPG and beta-docs for TPG.
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)