Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version field for unschematized hl7 stores #3983

Merged
merged 5 commits into from
Sep 25, 2020
Merged

add version field for unschematized hl7 stores #3983

merged 5 commits into from
Sep 25, 2020

Conversation

umairidris
Copy link
Member

@umairidris umairidris commented Sep 16, 2020

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

healthcare: Added field `parser_config.version` to `google_healthcare_hl7_v2_store`

@google-cla google-cla bot added the cla: yes label Sep 16, 2020
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@danawillow, please review this PR or find an appropriate assignee.

@umairidris umairidris changed the title [WIP] add version field for unschematized hl7 stores add version field for unschematized hl7 stores Sep 16, 2020
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 31 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 105 insertions(+), 6 deletions(-))
TF OiCS: Diff ( 6 files changed, 120 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=146824"

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 31 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 105 insertions(+), 6 deletions(-))
TF OiCS: Diff ( 6 files changed, 120 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=146834"

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@umairidris
Copy link
Member Author

@danawillow could you let me know the CB failure? I have verified the resource works by building from the modular magician PR and deploying a real resource.

@danawillow
Copy link
Contributor

The failure was on the changelog message. I'll rerun it now that that's been fixed.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 31 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 108 insertions(+), 6 deletions(-))
TF OiCS: Diff ( 6 files changed, 120 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=147242"

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, left some small nitpicks. Would you mind rebasing on top of master so we can try to get a clean CI run? It looks like this PR happened in the middle of some large changes people on our team have been making and so the cloud build is failing for reasons unrelated to this PR.

products/healthcare/api.yaml Outdated Show resolved Hide resolved
products/healthcare/api.yaml Outdated Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 31 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 108 insertions(+), 6 deletions(-))
TF OiCS: Diff ( 6 files changed, 120 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=148618"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceDnsManagedZone_basic|TestAccProviderMeta_setModuleName|TestAccBigQueryJob_bigqueryJobCopyTableReferenceExample|TestAccComputeDisk_deleteDetach|TestAccComputeInstanceTemplate_withScratchDisk|TestAccComputeInstance_diskEncryption|TestAccComputeInstance_bootDisk_source|TestAccComputeInstance_kmsDiskEncryption|TestAccComputeInstance_bootDisk_sourceUrl|TestAccComputePerInstanceConfig_update|TestAccComputeRegionDisk_deleteDetach|TestAccComputeRegionPerInstanceConfig_update|TestAccComputeSnapshot_encryptionCMEK|TestAccHealthcareHl7V2Store_healthcareHl7V2StoreUnschematizedExample|TestAccHealthcareHl7V2Store_healthcareHl7V2StoreParserConfigExample|TestAccHealthcareHl7V2Store_basic You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=148619"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants