Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rollout option to osconfig patch deployment fixes https://github.com/hashicorp/terraform-provider-google/issues/7124 #3919

Merged
merged 4 commits into from
Sep 1, 2020

Conversation

cookejames
Copy link
Contributor

@cookejames cookejames commented Aug 27, 2020

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

I have not tried to run the contributing tests yet. make test, and compiling the terraform module work.

make lint seems to run correctly for the osconfig module but has warning for other existing modules. These errors exist in master.

Release Note Template for Downstream PRs (will be copied)

osconfig: added rollout field to `google_os_config_patch_deployment`

@google-cla
Copy link

google-cla bot commented Aug 27, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Aug 27, 2020
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

@cookejames
Copy link
Contributor Author

@googlebot I signed it!

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 222 insertions(+))
Terraform Beta: Diff ( 2 files changed, 222 insertions(+))
TF Conversion: Diff ( 1 file changed, 70 insertions(+))

@slevenick
Copy link
Contributor

Hey @cookejames thanks for the contribution!

Can you add a test for this feature? It should be as easy as adding the rollout block to this file: https://github.com/GoogleCloudPlatform/magic-modules/blob/master/templates/terraform/examples/os_config_patch_deployment_full.tf.erb

which gets generated into the test for this resource.

products/osconfig/api.yaml Show resolved Hide resolved
products/osconfig/api.yaml Show resolved Hide resolved
products/osconfig/api.yaml Outdated Show resolved Hide resolved
@cookejames
Copy link
Contributor Author

Thanks for the comments this is the first time I've worked on magic modules so didn't realise that was an automated test I thought it was more for generating documentation. I've added a test and fixed the other points you have mentioned.

@cookejames cookejames requested a review from slevenick August 28, 2020 20:45
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 236 insertions(+))
Terraform Beta: Diff ( 3 files changed, 236 insertions(+))
TF Conversion: Diff ( 1 file changed, 70 insertions(+))
TF OiCS: Diff ( 1 file changed, 7 insertions(+))

products/osconfig/api.yaml Outdated Show resolved Hide resolved
@cookejames cookejames requested a review from slevenick September 1, 2020 09:42
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 236 insertions(+))
Terraform Beta: Diff ( 3 files changed, 236 insertions(+))
TF Conversion: Diff ( 1 file changed, 70 insertions(+))
TF OiCS: Diff ( 1 file changed, 7 insertions(+))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants