-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rollout option to osconfig patch deployment fixes https://github.com/hashicorp/terraform-provider-google/issues/7124 #3919
Add rollout option to osconfig patch deployment fixes https://github.com/hashicorp/terraform-provider-google/issues/7124 #3919
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @slevenick, please review this PR or find an appropriate assignee. |
@googlebot I signed it! |
Hey @cookejames thanks for the contribution! Can you add a test for this feature? It should be as easy as adding the rollout block to this file: https://github.com/GoogleCloudPlatform/magic-modules/blob/master/templates/terraform/examples/os_config_patch_deployment_full.tf.erb which gets generated into the test for this resource. |
Thanks for the comments this is the first time I've worked on magic modules so didn't realise that was an automated test I thought it was more for generating documentation. I've added a test and fixed the other points you have mentioned. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 236 insertions(+)) |
templates/terraform/examples/os_config_patch_deployment_full.tf.erb
Outdated
Show resolved
Hide resolved
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 236 insertions(+)) |
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.I have not tried to run the contributing tests yet.
make test
, and compiling the terraform module work.make lint
seems to run correctly for the osconfig module but has warning for other existing modules. These errors exist in master.Release Note Template for Downstream PRs (will be copied)