-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skip_initial_version_creation to kms crypto key #3907
Add skip_initial_version_creation to kms crypto key #3907
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @ndmckinley, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 4 files changed, 24 insertions(+), 5 deletions(-)) |
bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, running the tests now.
Tests fail:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know when you are able to fix the tests.
@ndmckinley There is something funny going on with the generator. The generator creates https://github.com/modular-magician/terraform-provider-google/compare/auto-pr-3907-old..auto-pr-3907#diff-346cd5ad8c45f2a15aa092b8af793d74R170 From the generated code earlier.
|
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 11 files changed, 38 insertions(+), 19 deletions(-)) |
Okay, just one more problem:
Same issue in |
…tokey-skip-init-version
It is fixed now |
… into cryptokey-skip-init-version
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 11 files changed, 42 insertions(+), 19 deletions(-)) |
1 similar comment
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 11 files changed, 42 insertions(+), 19 deletions(-)) |
The tests are still failing for me. Are they working for you?
|
Hmm, I ran the |
Works fine.
|
I bumped the api client in another PR which is breaking things.
|
Are you running the tests in the beta provider, or the GA one? I am using the beta provider. |
Beta provider |
Have a look at this gist. https://gist.github.com/upodroid/6f7863b33632ce14be43064dba3d30fa |
Hm, that's very odd. I'll rerun generation and see what happens. |
/gcbrun |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=154637" |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 11 files changed, 42 insertions(+), 19 deletions(-)) |
Yep, passed for me this time! Okay, merging. |
Cool |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceSpannerInstance_basic|TestAccBigQueryJob_bigqueryJobCopyExample|TestAccBigQueryJob_bigqueryJobCopyTableReferenceExample|TestAccBigqueryDataTransferConfig|TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample|TestAccCloudAssetProjectFeed_cloudAssetProjectFeedExample|TestAccCloudAssetOrganizationFeed_cloudAssetOrganizationFeedExample|TestAccComputeInstanceFromTemplate_overrideScratchDisk|TestAccComputeInstanceFromTemplate_overrideAttachedDisk|TestAccComputeInstanceFromTemplate_basic|TestAccComputeInstanceFromTemplate_overrideBootDisk|TestAccComputeInstanceFromTemplate_012_removableFields|TestAccComputeInstanceFromTemplate_overrideMetadataDotStartupScript|TestAccKmsCryptoKey_basic|TestAccKmsCryptoKeyIamBinding|TestAccKmsCryptoKey_template|TestAccKmsCryptoKeyIamMember|TestAccKmsCryptoKeyIamBinding_withCondition|TestAccKmsCryptoKeyIamMember_withCondition|TestAccKmsCryptoKeyIamPolicy|TestAccKmsCryptoKeyIamPolicy_withCondition You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=154643" |
Fixes: hashicorp/terraform-provider-google#7087
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)