-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Erase Windows VSS support to compute disk #3898
Add Erase Windows VSS support to compute disk #3898
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @c2thorn, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 89 insertions(+), 2 deletions(-)) |
@upodroid Hey! Someone else was going to take up adding the multiwriter option, and I never assigned the task to them, so that is my fault. However you have a few other fields added here, do you mind adding a test? Particularly for |
I added a new test, however I'm receiving 50X from Google. Internal Error. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 89 insertions(+), 2 deletions(-)) |
@upodroid Yeah looks like the feature is still in alpha, and isn't enabled by default in projects. we can remove this feature from this PR so we can merge your other changes? |
It is done. I updated the PR Title and changelog to refer to this. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 4 files changed, 94 insertions(+), 7 deletions(-)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor test naming fix, but looks good otherwise
Co-authored-by: Cameron Thornton <[email protected]>
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 4 files changed, 94 insertions(+), 7 deletions(-)) |
updated user facing examples to use debian 9 instead of debian 8.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)