Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Erase Windows VSS support to compute disk #3898

Merged
merged 6 commits into from
Aug 27, 2020

Conversation

upodroid
Copy link
Contributor

@upodroid upodroid commented Aug 24, 2020

updated user facing examples to use debian 9 instead of debian 8.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added `erase_windows_vss_signature` field to `google_compute_disk` (beta)

@google-cla google-cla bot added the cla: yes label Aug 24, 2020
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@c2thorn, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 89 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 151 insertions(+), 4 deletions(-))
Ansible: Diff ( 2 files changed, 114 insertions(+), 18 deletions(-))
TF Conversion: Diff ( 1 file changed, 33 insertions(+))
TF OiCS: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Inspec: Diff ( 7 files changed, 30 insertions(+), 1 deletion(-))

@c2thorn
Copy link
Member

c2thorn commented Aug 24, 2020

@upodroid Hey! Someone else was going to take up adding the multiwriter option, and I never assigned the task to them, so that is my fault. However you have a few other fields added here, do you mind adding a test? Particularly for eraseWindowsVssSignature

@upodroid
Copy link
Contributor Author

I added a new test, however I'm receiving 50X from Google. Internal Error.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 89 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 207 insertions(+), 4 deletions(-))
Ansible: Diff ( 2 files changed, 114 insertions(+), 18 deletions(-))
TF Conversion: Diff ( 1 file changed, 33 insertions(+))
TF OiCS: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Inspec: Diff ( 7 files changed, 30 insertions(+), 1 deletion(-))

@c2thorn
Copy link
Member

c2thorn commented Aug 26, 2020

@upodroid Yeah looks like the feature is still in alpha, and isn't enabled by default in projects. we can remove this feature from this PR so we can merge your other changes?

@upodroid upodroid changed the title Add Multiwriter support to compute disk Add Erase Windows VSS support to compute disk Aug 26, 2020
@upodroid
Copy link
Contributor Author

It is done. I updated the PR Title and changelog to refer to this.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 94 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 7 files changed, 182 insertions(+), 9 deletions(-))
Ansible: Diff ( 2 files changed, 114 insertions(+), 18 deletions(-))
TF Conversion: Diff ( 1 file changed, 33 insertions(+))
TF OiCS: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Inspec: Diff ( 7 files changed, 23 insertions(+), 1 deletion(-))

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor test naming fix, but looks good otherwise

Co-authored-by: Cameron Thornton <[email protected]>
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 94 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 7 files changed, 182 insertions(+), 9 deletions(-))
Ansible: Diff ( 2 files changed, 114 insertions(+), 18 deletions(-))
TF Conversion: Diff ( 1 file changed, 33 insertions(+))
TF OiCS: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Inspec: Diff ( 7 files changed, 23 insertions(+), 1 deletion(-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants