Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop recommendation to use -provider= on import #3894

Merged
merged 2 commits into from
Aug 25, 2020
Merged

Drop recommendation to use -provider= on import #3894

merged 2 commits into from
Aug 25, 2020

Conversation

sethvargo
Copy link
Member

@sethvargo sethvargo commented Aug 21, 2020

This was deprecated in 0.12 and is removed in 0.13.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Drop recommendation to use -provider= on import in documentation

This was deprecated in 0.12 and is removed in 0.13.
@google-cla google-cla bot added the cla: yes label Aug 21, 2020
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@megan07, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 151 files changed, 453 deletions(-))
Terraform Beta: Diff ( 182 files changed, 86 insertions(+), 632 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=141465"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccBigqueryDataTransferConfig|TestAccComputeInstanceFromTemplate_basic|TestAccContainerNodePool_withInvalidKubeletCpuManagerPolicy|TestAccPubsubSubscription_pubsubSubscriptionPullExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=141471"

Copy link
Contributor

@megan07 megan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! We probably want to look through other, non-generated, documentation and make these changes as well. I can open a new issue for that, if you don't want to include it here.

@sethvargo
Copy link
Member Author

@megan07 done

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 177 files changed, 3 insertions(+), 528 deletions(-))
Terraform Beta: Diff ( 211 files changed, 95 insertions(+), 722 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142272"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccContainerNodePool_withInvalidKubeletCpuManagerPolicy You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142274"

@megan07 megan07 merged commit e7c510b into GoogleCloudPlatform:master Aug 25, 2020
@megan07
Copy link
Contributor

megan07 commented Aug 25, 2020

@sethvargo thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants