-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notificationPubsubTopic
to BigQuery Data Transfer
#3881
Add notificationPubsubTopic
to BigQuery Data Transfer
#3881
Conversation
82c839e
to
9778268
Compare
9778268
to
90d1626
Compare
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @danawillow, please review this PR or find an appropriate assignee. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @14kw!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry, had one quick comment.
@@ -164,6 +164,10 @@ resource "google_bigquery_dataset" "my_dataset" { | |||
location = "asia-northeast1" | |||
} | |||
|
|||
resource "google_pubsub_topic" "my_topic" { | |||
name = "my_topic" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be given a name with randomness like we do for the dataset? That'll make sure separate test runs don't conflict. Also starting it with tf-test
is a good practice because we have some automation that cleans up resources in our test environment with that prefix.
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 44 insertions(+), 1 deletion(-)) |
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
part of hashicorp/terraform-provider-google#5866