Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notificationPubsubTopic to BigQuery Data Transfer #3881

Conversation

14kw
Copy link
Contributor

@14kw 14kw commented Aug 18, 2020

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigquery: added `notification_pubsub_topic` field to `google_bigquery_data_transfer_config` resource

part of hashicorp/terraform-provider-google#5866

@google-cla google-cla bot added the cla: yes label Aug 18, 2020
@14kw 14kw force-pushed the feature/support-bigquery-transfer-config-notification-pubsub-topic branch from 82c839e to 9778268 Compare August 18, 2020 11:45
@14kw 14kw force-pushed the feature/support-bigquery-transfer-config-notification-pubsub-topic branch from 9778268 to 90d1626 Compare August 20, 2020 00:25
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@danawillow, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 43 insertions(+))
Terraform Beta: Diff ( 3 files changed, 43 insertions(+))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @14kw!

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, had one quick comment.

@@ -164,6 +164,10 @@ resource "google_bigquery_dataset" "my_dataset" {
location = "asia-northeast1"
}

resource "google_pubsub_topic" "my_topic" {
name = "my_topic"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be given a name with randomness like we do for the dataset? That'll make sure separate test runs don't conflict. Also starting it with tf-test is a good practice because we have some automation that cleans up resources in our test environment with that prefix.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 44 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 44 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants