-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for BigQuery table ACLs #3856
Add support for BigQuery table ACLs #3856
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as long as the generated IAM tests pass.
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=139400" |
removed the commented line
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=139401" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGameServicesGameServerDeploymentRollout_basic|TestAccDataSourceGoogleComputeInstanceGroup_fromIGM|TestAccBigQueryTableIamBindingGenerated|TestAccBigQueryTableIamMemberGenerated|TestAccBigQueryTableIamPolicyGenerated|TestAccCloudBuildTrigger_cloudbuildTriggerBuildExample|TestAccCloudBuildTrigger_basic|TestAccComputeAutoscaler_update|TestAccComputeAutoscaler_multicondition|TestAccComputeBackendService_internalLoadBalancing|TestAccComputeImage_sourceImage|TestAccComputeImage_sourceSnapshot|TestAccComputeInstanceTemplate_shieldedVmConfig2|TestAccComputeInstanceTemplate_shieldedVmConfig1|TestAccComputeInstance_shieldedVmConfig1|TestAccComputeInstance_shieldedVmConfig2|TestAccComputeRegionAutoscaler_update|TestAccContainerCluster_withReleaseChannelEnabled|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_withInvalidReleaseChannel|TestAccContainerCluster_misc|TestAccGameServicesGameServerCluster_gameServiceClusterBasicExample|TestAccGameServicesGameServerConfig_gameServiceConfigBasicExample|TestAccGameServicesGameServerDeployment_gameServiceDeploymentBasicExample|TestAccGameServicesGameServerDeploymentRollout_gameServiceDeploymentRolloutBasicExample|TestAccGameServicesRealm_gameServiceRealmBasicExample|TestAccEndpointsService_basic|TestAccFolderIamAuditConfig_multiple|TestAccServiceAccountKey_fromCertificate|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample|TestAccPubsubSubscription_basic|TestAccPubsubSubscription_update|TestAccRedisInstance_redisInstanceFullExample|TestAccRedisInstance_redisInstancePrivateServiceExample|TestAccSqlDatabaseInstance_dontDeleteDefaultUserOnReplica|TestAccSqlDatabaseInstance_replica|TestAccSqlDatabaseInstance_settings_basic|TestAccSqlDatabaseInstance_slave|TestAccSqlDatabaseInstance_highAvailability|TestAccSqlDatabaseInstance_settingsDowngrade|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled|TestAccSqlDatabaseInstance_settings_upgrade|TestAccSqlDatabaseInstance_authNets|TestAccSqlDatabaseInstance_basic_with_user_labels You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=139404" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGameServicesGameServerDeploymentRollout_basic|TestAccDataSourceGoogleComputeInstanceGroup_fromIGM|TestAccBigQueryTableIamBindingGenerated|TestAccBigQueryTableIamMemberGenerated|TestAccBigQueryTableIamPolicyGenerated|TestAccCloudBuildTrigger_cloudbuildTriggerBuildExample|TestAccCloudBuildTrigger_basic|TestAccComputeAutoscaler_update|TestAccComputeAutoscaler_multicondition|TestAccComputeBackendService_internalLoadBalancing|TestAccComputeImage_sourceImage|TestAccComputeImage_sourceSnapshot|TestAccComputeInstanceTemplate_shieldedVmConfig1|TestAccComputeInstanceTemplate_shieldedVmConfig2|TestAccComputeInstance_shieldedVmConfig1|TestAccComputeInstance_shieldedVmConfig2|TestAccComputeRegionAutoscaler_update|TestAccContainerCluster_withReleaseChannelEnabled|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_withInvalidReleaseChannel|TestAccContainerCluster_misc|TestAccGameServicesGameServerCluster_gameServiceClusterBasicExample|TestAccGameServicesGameServerConfig_gameServiceConfigBasicExample|TestAccGameServicesGameServerDeployment_gameServiceDeploymentBasicExample|TestAccGameServicesGameServerDeploymentRollout_gameServiceDeploymentRolloutBasicExample|TestAccGameServicesRealm_gameServiceRealmBasicExample|TestAccEndpointsService_basic|TestAccFolderIamAuditConfig_multiple|TestAccServiceAccountKey_fromCertificate|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample|TestAccPubsubSubscription_basic|TestAccPubsubSubscription_update|TestAccRedisInstance_redisInstanceFullExample|TestAccRedisInstance_redisInstancePrivateServiceExample|TestAccSqlDatabaseInstance_dontDeleteDefaultUserOnReplica|TestAccSqlDatabaseInstance_replica|TestAccSqlDatabaseInstance_settings_basic|TestAccSqlDatabaseInstance_slave|TestAccSqlDatabaseInstance_highAvailability|TestAccSqlDatabaseInstance_settingsDowngrade|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled|TestAccSqlDatabaseInstance_settings_upgrade|TestAccSqlDatabaseInstance_authNets|TestAccSqlDatabaseInstance_basic_with_user_labels You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=139407" |
All three tests passed locally |
Fixes hashicorp/terraform-provider-google#6561
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)