Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move shieldedvmconfig -> shieldedinstanceconfig due to rename. #3822

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

nat-henderson
Copy link
Contributor

@nat-henderson nat-henderson commented Aug 4, 2020

Release Note Template for Downstream PRs (will be copied)

compute: fix shielded instance config, which had been failing to apply due to a field rename on the GCP side.

Fixes hashicorp/terraform-provider-google#6900.
Fixes hashicorp/terraform-provider-google#6913.

@google-cla google-cla bot added the cla: yes label Aug 4, 2020
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 39 insertions(+), 39 deletions(-))
Terraform Beta: Diff ( 4 files changed, 39 insertions(+), 39 deletions(-))
TF Conversion: Diff ( 1 file changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=137652"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeInstanceTemplate_shieldedVmConfig2|TestAccComputeInstanceTemplate_shieldedVmConfig1|TestAccComputeInstance_shieldedVmConfig1|TestAccComputeInstance_shieldedVmConfig2|TestAccEndpointsService_basic|TestAccFolderIamAuditConfig_multiple|TestAccRedisInstance_redisInstancePrivateServiceExample|TestAccRedisInstance_redisInstanceFullExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=137653"

@nat-henderson
Copy link
Contributor Author

Cool, looks like those tests pass in recording mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants