-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add os config patch deployment resource #3721
Conversation
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 7 files changed, 4213 insertions(+), 2 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=129567" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFolderIamAuditConfig_multiple|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentBasicExample|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentInstanceExample|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=129568" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks like it was a lot of work, and it seems very thoroughly tested, awesome. And I see the VCR recording works too, which is great. Thank you!
products/osconfig/api.yaml
Outdated
- patch_config.0.reboot_config | ||
- patch_config.0.apt | ||
- patch_config.0.yum | ||
# - patch_config.0.goo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want this to stay commented out, or should it be removed (here and elsewhere)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ndmckinley - thanks for the reminder! I meant to test this out. It's an empty block in the API, so I wasn't sure how to add it in here, but I just made it nested with enabled
. Not sure if that makes sense, or if that could potentially mess up other downstreams (if they end up using this). I'd appreciate your thoughts/suggestions here!
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 7 files changed, 4338 insertions(+), 2 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=130277" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccOSConfigPatchDeployment_osConfigPatchDeploymentBasicExample|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentInstanceExample|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=130278" |
Fixes hashicorp/terraform-provider-google#6270
add os config patch deployment resource
Release Note Template for Downstream PRs (will be copied)