Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cloud identity data sources #3714

Merged
merged 4 commits into from
Jun 26, 2020

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Jun 26, 2020

Fixes hashicorp/terraform-provider-google#6704

Release Note Template for Downstream PRs (will be copied)

`google_cloud_identity_groups`
`google_cloud_identity_group_memberships`

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 177 insertions(+))
Terraform Beta: Diff ( 9 files changed, 402 insertions(+))
TF Conversion: Diff ( 1 file changed, 13 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=123210"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 164 insertions(+))
Terraform Beta: Diff ( 9 files changed, 402 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=123212"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFolderIamAuditConfig_multiple You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=123214"

@megan07 megan07 requested a review from danawillow June 26, 2020 19:47
@danawillow
Copy link
Contributor

Would you mind requesting someone else for the review? I've got some other things on my plate that I'd like to get done today.

@megan07 megan07 requested review from c2thorn and removed request for danawillow June 26, 2020 20:03
Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloud Identity Group datasources
5 participants