-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mode and scaleDownControls for Compute Region AutoScaler #3701
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @rileykarson, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 43 insertions(+), 48 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=122438" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rajatvig!
@rileykarson I don't see the changes from this PR released for v3.28 of the provider. I see the changes in https://github.com/terraform-providers/terraform-provider-google |
Same state for the beta provider. Seems the last release based off https://github.com/terraform-providers/terraform-provider-google/blob/v3.28.0/website/docs/r/compute_region_autoscaler.html.markdown was in April |
This should get released as part of |
Related to #3693.
Adds support for
mode
andscaleDownControls
for ComputeRegionAutoScalerRelease Note Template for Downstream PRs (will be copied)