Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mode and scaleDownControls for Compute Region AutoScaler #3701

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

rajatvig
Copy link
Contributor

Related to #3693.
Adds support for mode and scaleDownControls for ComputeRegionAutoScaler

Release Note Template for Downstream PRs (will be copied)

compute: Added `mode` to `google_compute_region_autoscaler` `autoscaling_policy`
compute: Added `scale_down_control ` to `google_compute_region_autoscaler` `autoscaling_policy` (beta only)

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 43 insertions(+), 48 deletions(-))
Terraform Beta: Diff ( 3 files changed, 313 insertions(+), 44 deletions(-))
Ansible: Diff ( 2 files changed, 20 insertions(+))
TF Conversion: Diff ( 1 file changed, 11 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=122438"

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rajatvig!

@rajatvig
Copy link
Contributor Author

@rileykarson I don't see the changes from this PR released for v3.28 of the provider. I see the changes in https://github.com/terraform-providers/terraform-provider-google master branch but not in the tagged 3.28 release

@rajatvig
Copy link
Contributor Author

Same state for the beta provider. Seems the last release based off https://github.com/terraform-providers/terraform-provider-google/blob/v3.28.0/website/docs/r/compute_region_autoscaler.html.markdown was in April

@rileykarson
Copy link
Member

This should get released as part of 3.29.0 next week! Sorry for the delay- we typically cut a release branch on Wednesday based on the last commit on Tuesday, then release it the following Monday. Since this was merged last Wednesday, it will be in the branch cut today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants