Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send empty/false for import/export custom routes #3661

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

emilymye
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

compute: Allow updating `google_compute_network_peering_routes_config ` `import_custom_routes` and  `export_custom_routes` to false

Fixes hashicorp/terraform-provider-google#6614

@emilymye emilymye force-pushed the sendemptypeeringcfg branch from 92e0bff to 70886c5 Compare June 17, 2020 18:21
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=121132"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_compute_network_peering_routes_config fails to disable import/export custom routes
4 participants