Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add min_node_cpus to compute_instance.scheduling #3634

Merged
merged 2 commits into from
Jun 12, 2020

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Jun 12, 2020

Fixes hashicorp/terraform-provider-google#5416

Add min_node_cpus to compute_instance.scheduling and compute_instance_template.scheduling

Release Note Template for Downstream PRs (will be copied)

compute: added `min_node_cpus` to the `scheduling` blocks on `compute_instance` and `compute_instance_template`

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 13 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 5 files changed, 37 insertions(+), 6 deletions(-))
TF Conversion: Diff ( 1 file changed, 17 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=119872"

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 13 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 5 files changed, 37 insertions(+), 6 deletions(-))
TF Conversion: Diff ( 1 file changed, 17 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=119876"

@megan07 megan07 requested a review from nat-henderson June 12, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation of minNodeCpus
4 participants