Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and document id format for google_kms_crypto_key_version. #3624

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

rileykarson
Copy link
Member

Fixes hashicorp/terraform-provider-google#6538

Release Note Template for Downstream PRs (will be copied)

kms: fixed the `id` value in the `google_kms_crypto_key_version` datasource to include an `/v1` part following `//cloudkms.googleapis.com/`, making it useful for interpolation into Binary Authorization.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 3 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 3 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=119272"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_binary_authorization_attestor KMS public_key id does not reference cloudkms v1
4 participants