Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Network Management ConnectivityTest resource #3601

Merged
merged 4 commits into from
Jun 4, 2020

Conversation

emilymye
Copy link
Contributor

@emilymye emilymye commented Jun 3, 2020

Release Note Template for Downstream PRs (will be copied)

`google_network_management_connectivity_test`

Also:

  • Added a new override to MMv1 for the name of the resource in the filename only .
    • Prevent resource file from ending in "test" and treated as a Go test (_test.go pattern) while still keeping the name of the resource short

@emilymye emilymye force-pushed the networkmanagement branch 3 times, most recently from 150085f to 4ca1922 Compare June 3, 2020 18:33
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

2 similar comments
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@emilymye emilymye force-pushed the networkmanagement branch from 795d786 to 6b726e4 Compare June 3, 2020 20:25
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 1748 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1748 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 269 insertions(+))
TF OiCS: Diff ( 8 files changed, 301 insertions(+))

@emilymye emilymye requested a review from c2thorn June 3, 2020 20:44
Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One questionable resource description, but overall looks good!

products/networkmanagement/api.yaml Outdated Show resolved Hide resolved
products/networkmanagement/api.yaml Outdated Show resolved Hide resolved
products/networkmanagement/terraform.yaml Show resolved Hide resolved
# limitations under the License.
-%>
func expand<%= prefix -%><%= titlelize_property(property) -%>(v interface{}, d TerraformResourceData, config *Config) (interface{}, error) {
// projects/X/tests/Y - note not "connectivityTests"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boo!

@emilymye emilymye force-pushed the networkmanagement branch from 0aa2fdc to 7fa9b18 Compare June 4, 2020 00:26
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 1755 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1755 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 269 insertions(+))
TF OiCS: Diff ( 8 files changed, 301 insertions(+))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants