Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cloudbuild] Add invertRegex for GitHub filters #3558

Closed

Conversation

Maks3w
Copy link

@Maks3w Maks3w commented May 23, 2020

https://cloud.google.com/cloud-build/docs/api/reference/rest/v1/projects.triggers#pullrequestfilter
https://cloud.google.com/cloud-build/docs/api/reference/rest/v1/projects.triggers#PushFilter

Release Note Template for Downstream PRs (will be copied)

cloudbuild: Added `invert_regex` for GitHub PushFilter and PullRequestFilter triggers

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 2 files changed, 52 insertions(+))
Inspec: Diff ( 3 files changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • release-note:enhancement

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@Maks3w Maks3w closed this May 23, 2020
@Maks3w Maks3w reopened this May 23, 2020
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 2 files changed, 52 insertions(+))
Inspec: Diff ( 3 files changed, 10 insertions(+))

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danawillow
Copy link
Contributor

Closing, was added in #3628

@danawillow danawillow closed this Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants