continue updates for view=full app engine version #3545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 593 insertions(+), 17 deletions(-)) |
slevenick
approved these changes
May 21, 2020
slevenick
reviewed
May 21, 2020
| Path to the script from the application root directory. | ||
| - !ruby/object:Api::Type::NestedObject | ||
| name: 'staticFiles' | ||
| # TODO (mbang): Exactly one of script, staticFiles, or apiEndpoint must be set |
There was a problem hiding this comment.
unfortunately, we still can't, because it's a child of an array
megan07
requested review from
c2thorn
and removed request for
emilymye and
c2thorn
This was referenced May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More changes to follow #3536
Fixes hashicorp/terraform-provider-google#6417
Release Note Template for Downstream PRs (will be copied)