Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exact domain matching for organization data source #3534

Merged
merged 1 commit into from
May 19, 2020

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented May 19, 2020

Fixes hashicorp/terraform-provider-google#6366

Release Note Template for Downstream PRs (will be copied)

Fixed an issue where data source `google_organization` would ignore exact domain matches if multiple domains were found

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 12 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 12 insertions(+), 2 deletions(-))

@c2thorn c2thorn requested a review from slevenick May 19, 2020 16:53
Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confusing that display name is actually the domain name of the org...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More than one matching organization found
4 participants