Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow update of node pool workload metadata config #3512

Merged
merged 4 commits into from
May 20, 2020

Conversation

emilymye
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

container: Added update support for `node_config.workload_metadata_config` to `google_container_node_pool`

Fixes hashicorp/terraform-provider-google#4041

This field is only updatable on node pool, so we've chosen to only make it updatable on node_pool and keep it ForceNew on container cluster

In addition, because cluster.workload_identity_config and node_pool.workload_metadata_config are closely related, I decided to combine the test

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 233 insertions(+), 189 deletions(-))
Terraform Beta: Diff ( 4 files changed, 255 insertions(+), 212 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 247 insertions(+), 189 deletions(-))
Terraform Beta: Diff ( 5 files changed, 273 insertions(+), 224 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 215 insertions(+), 190 deletions(-))
Terraform Beta: Diff ( 5 files changed, 272 insertions(+), 224 deletions(-))

@emilymye emilymye force-pushed the nodeworkloadmetadata branch from 1741280 to bfd2ef0 Compare May 14, 2020 23:20
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 215 insertions(+), 190 deletions(-))
Terraform Beta: Diff ( 5 files changed, 272 insertions(+), 249 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 215 insertions(+), 190 deletions(-))
Terraform Beta: Diff ( 5 files changed, 272 insertions(+), 267 deletions(-))

@emilymye emilymye force-pushed the nodeworkloadmetadata branch from 63975ff to 22c5a0a Compare May 15, 2020 02:11
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 215 insertions(+), 190 deletions(-))
Terraform Beta: Diff ( 4 files changed, 268 insertions(+), 212 deletions(-))

@emilymye emilymye requested a review from slevenick May 15, 2020 15:11
third_party/terraform/utils/node_config.go.erb Outdated Show resolved Hide resolved
Type: schema.TypeString,
Required: true,
ValidateFunc: validation.StringInSlice([]string{"gvisor"}, false),
"sandbox_config": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We removed ForceNew from sandbox_config but the code seems to only apply to workload_metadata_config, how does that work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i for sure removed it from the wrong config when transferring over to MM

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 214 insertions(+), 190 deletions(-))
Terraform Beta: Diff ( 4 files changed, 267 insertions(+), 212 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 216 insertions(+), 190 deletions(-))
Terraform Beta: Diff ( 5 files changed, 269 insertions(+), 212 deletions(-))
TF Conversion: Diff ( 1 file changed, 13 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 217 insertions(+), 190 deletions(-))
Terraform Beta: Diff ( 5 files changed, 270 insertions(+), 212 deletions(-))
TF Conversion: Diff ( 1 file changed, 13 insertions(+))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update workload_metadata_config.node_metadata on node pools without force replacement.
4 participants