-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow update of node pool workload metadata config #3512
Allow update of node pool workload metadata config #3512
Conversation
1741280
to
bfd2ef0
Compare
63975ff
to
22c5a0a
Compare
third_party/terraform/resources/resource_container_cluster.go.erb
Outdated
Show resolved
Hide resolved
Type: schema.TypeString, | ||
Required: true, | ||
ValidateFunc: validation.StringInSlice([]string{"gvisor"}, false), | ||
"sandbox_config": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We removed ForceNew from sandbox_config
but the code seems to only apply to workload_metadata_config, how does that work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i for sure removed it from the wrong config when transferring over to MM
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 4 files changed, 216 insertions(+), 190 deletions(-)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 4 files changed, 217 insertions(+), 190 deletions(-)) |
Release Note Template for Downstream PRs (will be copied)
Fixes hashicorp/terraform-provider-google#4041
This field is only updatable on node pool, so we've chosen to only make it updatable on
node_pool
and keep it ForceNew on container clusterIn addition, because cluster.workload_identity_config and node_pool.workload_metadata_config are closely related, I decided to combine the test