-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for request-based SLIs in monitoring SLO #3491
Conversation
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 35 files changed, 853 insertions(+), 121 deletions(-)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 35 files changed, 771 insertions(+), 14 deletions(-)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 6 files changed, 739 insertions(+), 14 deletions(-)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 35 files changed, 951 insertions(+), 118 deletions(-)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 6 files changed, 739 insertions(+), 14 deletions(-)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 6 files changed, 739 insertions(+), 14 deletions(-)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 6 files changed, 757 insertions(+), 15 deletions(-)) |
1 similar comment
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 6 files changed, 757 insertions(+), 15 deletions(-)) |
@@ -13,3 +13,13 @@ | |||
|
|||
--- !ruby/object:Provider::Terraform::Config | |||
overrides: !ruby/object:Overrides::ResourceOverrides | |||
ResourceWithTerraformOverride: !ruby/object:Overrides::Terraform::ResourceOverride |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between this file and good-tf-override.yaml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good-tf-override.yaml is used to determine whether the overriding is working? for provider_terraform_resource_override_spec - I'm not against seeing if we can combine them or at least renaming these files (and cleaning any unused files up) so they are less confusing. Would probably do in a different PR
…atform#3491) * initial slo resource * whitespace and update mask * add exactly X of to slo descriptions * unit tests
Release Note Template for Downstream PRs (will be copied)