Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for request-based SLIs in monitoring SLO #3491

Merged
merged 4 commits into from
May 12, 2020

Conversation

emilymye
Copy link
Contributor

@emilymye emilymye commented May 9, 2020

Release Note Template for Downstream PRs (will be copied)

monitoring: Added `request_based` SLI support to `google_monitoring_slo` 

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 35 files changed, 853 insertions(+), 121 deletions(-))
Terraform Beta: Diff ( 47 files changed, 883 insertions(+), 151 deletions(-))
TF Conversion: Diff ( 1 file changed, 142 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 35 files changed, 771 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 47 files changed, 783 insertions(+), 14 deletions(-))
TF Conversion: Diff ( 1 file changed, 142 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 739 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 6 files changed, 739 insertions(+), 14 deletions(-))
TF Conversion: Diff ( 1 file changed, 142 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 35 files changed, 951 insertions(+), 118 deletions(-))
Terraform Beta: Diff ( 47 files changed, 1011 insertions(+), 148 deletions(-))
TF Conversion: Diff ( 1 file changed, 142 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 739 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 6 files changed, 739 insertions(+), 14 deletions(-))
TF Conversion: Diff ( 1 file changed, 142 insertions(+))

@emilymye emilymye requested review from danawillow and slevenick May 11, 2020 17:03
provider/terraform.rb Show resolved Hide resolved
products/monitoring/api.yaml Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 739 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 6 files changed, 739 insertions(+), 14 deletions(-))
TF Conversion: Diff ( 1 file changed, 142 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 757 insertions(+), 15 deletions(-))
Terraform Beta: Diff ( 6 files changed, 757 insertions(+), 15 deletions(-))
TF Conversion: Diff ( 1 file changed, 142 insertions(+))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 757 insertions(+), 15 deletions(-))
Terraform Beta: Diff ( 6 files changed, 757 insertions(+), 15 deletions(-))
TF Conversion: Diff ( 1 file changed, 142 insertions(+))

@@ -13,3 +13,13 @@

--- !ruby/object:Provider::Terraform::Config
overrides: !ruby/object:Overrides::ResourceOverrides
ResourceWithTerraformOverride: !ruby/object:Overrides::Terraform::ResourceOverride
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between this file and good-tf-override.yaml?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good-tf-override.yaml is used to determine whether the overriding is working? for provider_terraform_resource_override_spec - I'm not against seeing if we can combine them or at least renaming these files (and cleaning any unused files up) so they are less confusing. Would probably do in a different PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants