-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix node pool tests. #3475
Merged
nat-henderson
merged 3 commits into
GoogleCloudPlatform:master
from
nat-henderson:container-default-api
May 14, 2020
Merged
Fix node pool tests. #3475
nat-henderson
merged 3 commits into
GoogleCloudPlatform:master
from
nat-henderson:container-default-api
May 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nat-henderson
force-pushed
the
container-default-api
branch
from
May 11, 2020 22:20
015ec79
to
07d9536
Compare
Anything preventing this from getting in? |
Just the review! I'll assign you? |
danawillow
approved these changes
May 14, 2020
This was referenced May 14, 2020
nathkn
pushed a commit
to nathkn/magic-modules
that referenced
this pull request
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core problem here is that the available node versions are such that
version (max - 1) is not compatible with the latest master version.
Fixes hashicorp/terraform-provider-google#6283.
Release Note Template for Downstream PRs (will be copied)