Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move enable_shielded_nodes from beta to GA. #3472

Merged

Conversation

nat-henderson
Copy link
Contributor

Fixes hashicorp/terraform-provider-google#6269.

Release Note Template for Downstream PRs (will be copied)

container: Moved `google_container_cluster.enable_shielded_nodes` from beta to GA.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 66 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 31 insertions(+), 31 deletions(-))

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we also need to move the config testAccContainerCluster_withShieldedNodes to GA

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 78 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 44 insertions(+), 43 deletions(-))

@slevenick slevenick self-requested a review May 5, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promote enable_shielded_nodes argument
4 participants