Promote region* compute services to GA #3381

ctavan · 2020-04-15T20:35:22Z

Many of the region* resources are still marked as beta (at least for terraform). Some beta-restrictions were lifted in the past:

But others still seem to be missing. Anything holding us back from promoting all the Region* resources to GA?

Release Note Template for Downstream PRs (will be copied)

`google_compute_region_url_map` is now GA

`google_compute_region_target_http_proxy` is now GA

`google_compute_region_target_https_proxy` is now GA

compute: Promoted the following `google_compute_backend_service` fields to GA: `circuit_breakers`, `consistent_hash`, `custom_request_headers`, `locality_lb_policy`, `outlier_detection`

compute: Promoted the following `google_compute_region_backend_service` fields to GA: `affinity_cookie_ttl_sec`,`circuit_breakers`, `consistent_hash`, `failover_policy`, `locality_lb_policy`, `outlier_detection`, `log_config`, `failover`

modular-magician · 2020-04-15T20:41:07Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 23 files changed, 11363 insertions(+), 33 deletions(-))
Terraform Beta: Diff ( 13 files changed, 71 insertions(+), 165 deletions(-))
Ansible: Diff ( 4 files changed, 4 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 3 files changed, 2246 insertions(+), 8 deletions(-))
TF OiCS: Diff ( 12 files changed, 67 deletions(-))

modular-magician · 2020-04-15T20:41:13Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

danawillow · 2020-04-21T22:38:37Z

Picking a reviewer randomly because of https://github.com/GoogleCloudPlatform/magic-modules/issues/3055.

c2thorn · 2020-04-24T21:15:30Z

Hi @ctavan, thanks for your submission!
There doesn't seem to be any issue with promoting these resources. At a quick glance these changes seem correct, but it'll take a bit of building/testing for me to verify (similar changes were made recently that ended up being somewhat complicated).
It's on my to-do list after a couple of priority items, thanks for your patience.

ctavan · 2020-04-25T07:39:44Z

@c2thorn I will have to rebase this branch since #3379 has been merged and introduced changes that affect the changes in here. Will let you know when I‘m done.

modular-magician · 2020-04-26T12:36:26Z

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@c2thorn, please review this PR or find an appropriate assignee.

ctavan · 2020-04-26T12:39:09Z

I did the rebase and the necessary changes due to #3379.

modular-magician · 2020-04-26T12:40:25Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 24 files changed, 12084 insertions(+), 33 deletions(-))
Terraform Beta: Diff ( 13 files changed, 77 insertions(+), 174 deletions(-))
Ansible: Diff ( 4 files changed, 4 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 3 files changed, 2435 insertions(+), 28 deletions(-))
TF OiCS: Diff ( 13 files changed, 71 deletions(-))

modular-magician · 2020-04-26T12:42:34Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician · 2020-04-27T21:24:47Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 24 files changed, 12084 insertions(+), 33 deletions(-))
Terraform Beta: Diff ( 13 files changed, 77 insertions(+), 174 deletions(-))
Ansible: Diff ( 4 files changed, 4 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 3 files changed, 2435 insertions(+), 28 deletions(-))
TF OiCS: Diff ( 13 files changed, 71 deletions(-))

c2thorn

Caught a couple of failing examples/tests here that I believe you can just revert, as they rely on beta-only fields. If it is your intention to promote these fields to GA as well, I recommend to separate them out into different PR's so they are easier to track/discuss.

products/compute/terraform.yaml

templates/terraform/examples/region_health_check_http_logs.tf.erb

third_party/terraform/tests/resource_compute_region_backend_service_test.go.erb

ctavan · 2020-04-28T08:46:33Z

Caught a couple of failing examples/tests here that I believe you can just revert, as they rely on beta-only fields. If it is your intention to promote these fields to GA as well, I recommend to separate them out into different PR's so they are easier to track/discuss.

Thanks for the review and sorry for not testing this properly before submitting. I think I got this sorted out now (see comments above) but did not extract the changes into a separate PR since the adjustments looked really straightforward. Would you still like me to do that? If so, how should I split the changes up?

modular-magician · 2020-04-28T08:51:01Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 27 files changed, 15923 insertions(+), 223 deletions(-))
Terraform Beta: Diff ( 13 files changed, 87 insertions(+), 185 deletions(-))
Ansible: Diff ( 8 files changed, 2344 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 5 files changed, 3406 insertions(+), 28 deletions(-))
TF OiCS: Diff ( 12 files changed, 69 deletions(-))
Inspec: Diff ( 4 files changed, 29 insertions(+), 29 deletions(-))

c2thorn · 2020-04-28T20:38:13Z

@ctavan I appreciate your cooperation and patience on this. There are quite a few changes here, but manual review looks good. Do you mind rebasing one more time, and then I'll be able to run tests against both providers. Once that clears, I can give the LGTM and merge.

…nd_service Currently there only seem to be two features in backend services that are not GA: --- v1.json +++ beta.json @@ -62,6 +62,10 @@ "enable": boolean, "sampleRate": number }, + "securitySettings": { + "authentication": string, + "subjectAltNames": [string] + }, "localityLbPolicy": enum, "consistentHash": { "httpCookie": { @@ -76,6 +80,10 @@ "minimumRingSize": string }, "circuitBreakers": { + "connectTimeout": { + "seconds": string, + "nanos": integer + }, "maxRequestsPerConnection": integer, "maxConnections": integer, "maxPendingRequests": integer,

ctavan · 2020-04-29T11:30:22Z

Done @c2thorn

modular-magician · 2020-04-29T11:35:32Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 27 files changed, 15921 insertions(+), 223 deletions(-))
Terraform Beta: Diff ( 13 files changed, 87 insertions(+), 185 deletions(-))
Ansible: Diff ( 8 files changed, 2344 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 5 files changed, 3406 insertions(+), 28 deletions(-))
TF OiCS: Diff ( 12 files changed, 69 deletions(-))
Inspec: Diff ( 4 files changed, 29 insertions(+), 29 deletions(-))

modular-magician · 2020-04-29T19:28:45Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 28 files changed, 16125 insertions(+), 223 deletions(-))
Terraform Beta: Diff ( 13 files changed, 105 insertions(+), 188 deletions(-))
Ansible: Diff ( 8 files changed, 2344 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 5 files changed, 3406 insertions(+), 28 deletions(-))
TF OiCS: Diff ( 12 files changed, 69 deletions(-))
Inspec: Diff ( 4 files changed, 29 insertions(+), 29 deletions(-))

c2thorn

A couple of more examples needed to be set to GA, but it looks good now

ctavan · 2020-04-29T20:51:48Z

Thank you for your efforts in completing my incomplete work @c2thorn 😇!

c2thorn · 2020-04-29T21:08:14Z

@ctavan No worries, thanks for contributing!

googlebot added the cla: yes label Apr 15, 2020

danawillow requested a review from c2thorn April 21, 2020 22:38

ctavan mentioned this pull request Apr 22, 2020

Add default url redirect to url maps #3379

Merged

ctavan force-pushed the promote-region-services-ga branch from 8a93245 to 8eed3c8 Compare April 26, 2020 12:35

modular-magician added the community label Apr 26, 2020

c2thorn requested changes Apr 27, 2020

View reviewed changes

products/compute/terraform.yaml Outdated Show resolved Hide resolved

templates/terraform/examples/region_health_check_http_logs.tf.erb Outdated Show resolved Hide resolved

third_party/terraform/tests/resource_compute_region_backend_service_test.go.erb Show resolved Hide resolved

ctavan force-pushed the promote-region-services-ga branch from 8eed3c8 to f94349f Compare April 28, 2020 08:45

ctavan added 3 commits April 29, 2020 13:27

Promote region* compute services to GA

f7e7665

Revert health check example to beta provider

2d70c92

ctavan force-pushed the promote-region-services-ga branch from f94349f to 2d70c92 Compare April 29, 2020 11:30

Remove min versions from rbs examples

69526d3

c2thorn approved these changes Apr 29, 2020

View reviewed changes

c2thorn merged commit 49a803f into GoogleCloudPlatform:master Apr 29, 2020

ctavan deleted the promote-region-services-ga branch April 29, 2020 21:14

nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020

Promote region* compute services to GA (GoogleCloudPlatform#3381)

f67230c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Promote region* compute services to GA #3381

Promote region* compute services to GA #3381

ctavan commented Apr 15, 2020 •

edited by c2thorn

Loading

modular-magician commented Apr 15, 2020

modular-magician commented Apr 15, 2020

danawillow commented Apr 21, 2020

c2thorn commented Apr 24, 2020 •

edited

Loading

ctavan commented Apr 25, 2020

modular-magician commented Apr 26, 2020

ctavan commented Apr 26, 2020

modular-magician commented Apr 26, 2020

modular-magician commented Apr 26, 2020

modular-magician commented Apr 27, 2020

c2thorn left a comment

ctavan commented Apr 28, 2020

modular-magician commented Apr 28, 2020

c2thorn commented Apr 28, 2020 •

edited

Loading

ctavan commented Apr 29, 2020

modular-magician commented Apr 29, 2020

modular-magician commented Apr 29, 2020

c2thorn left a comment

ctavan commented Apr 29, 2020

c2thorn commented Apr 29, 2020

Promote region* compute services to GA #3381

Promote region* compute services to GA #3381

Conversation

ctavan commented Apr 15, 2020 • edited by c2thorn Loading

modular-magician commented Apr 15, 2020

Diff report:

modular-magician commented Apr 15, 2020

danawillow commented Apr 21, 2020

c2thorn commented Apr 24, 2020 • edited Loading

ctavan commented Apr 25, 2020

modular-magician commented Apr 26, 2020

ctavan commented Apr 26, 2020

modular-magician commented Apr 26, 2020

Diff report:

modular-magician commented Apr 26, 2020

modular-magician commented Apr 27, 2020

Diff report:

c2thorn left a comment

Choose a reason for hiding this comment

ctavan commented Apr 28, 2020

modular-magician commented Apr 28, 2020

Diff report:

c2thorn commented Apr 28, 2020 • edited Loading

ctavan commented Apr 29, 2020

modular-magician commented Apr 29, 2020

Diff report:

modular-magician commented Apr 29, 2020

Diff report:

c2thorn left a comment

Choose a reason for hiding this comment

ctavan commented Apr 29, 2020

c2thorn commented Apr 29, 2020

ctavan commented Apr 15, 2020 •

edited by c2thorn

Loading

c2thorn commented Apr 24, 2020 •

edited

Loading

c2thorn commented Apr 28, 2020 •

edited

Loading