Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There must be one and only one newline after each documentation element. #336

Merged
merged 8 commits into from
Jul 10, 2018

Conversation

nat-henderson
Copy link
Contributor

This should include the changes necessary to fix the issue in hashicorp/terraform-provider-google#1732 once and for all. :) I'll build the website to make sure.


[all]

[terraform]

Magic Modules generated documentation cleanup.

[puppet]

[puppet-compute]

[puppet-sql]

[puppet-storage]

[chef]

[chef-compute]

[chef-sql]

[chef-storage]

[ansible]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google#1746

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit bf496d9) have been included in your existing downstream PRs.

@nat-henderson nat-henderson requested a review from danawillow July 9, 2018 21:21
@nat-henderson
Copy link
Contributor Author

I built the website! And, yep, it does work fine. :)

<%- unless object.docs.required_properties.nil? -%>
<%= lines(object.docs.required_properties) -%>
<%= "\n" + object.docs.required_properties -%>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment as to why lines doesn't work?

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 826032a) have been included in your existing downstream PRs.

Tracked submodules are build/puppet/compute build/puppet/sql build/puppet/storage build/chef/compute build/chef/sql build/chef/storage build/terraform build/ansible.
@modular-magician modular-magician merged commit b1bb39c into master Jul 10, 2018
@nat-henderson nat-henderson deleted the whitespace branch July 10, 2018 22:47
chrisst pushed a commit to chrisst/magic-modules that referenced this pull request Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants