Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health Check Logging #3346

Merged
merged 3 commits into from
Apr 6, 2020
Merged

Conversation

drebes
Copy link
Member

@drebes drebes commented Apr 6, 2020

Release Note Template for Downstream PRs (will be copied)

compute: Added field `log_config` to `google_compute_health_check` and `google_compute_region_health_check` to enable health check logging.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 67 insertions(+))
Terraform Beta: Diff ( 5 files changed, 231 insertions(+))
TF OiCS: Diff ( 4 files changed, 115 insertions(+))
Inspec: Diff ( 5 files changed, 44 insertions(+))

@drebes drebes requested a review from rileykarson April 6, 2020 07:48
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 24 insertions(+))
Terraform Beta: Diff ( 5 files changed, 226 insertions(+))
TF OiCS: Diff ( 4 files changed, 115 insertions(+))
Inspec: Diff ( 5 files changed, 44 insertions(+))

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding an example or handwritten test for google_compute_region_health_check too? Most of the load balancing resources support the same fields between regional/global or regional/zonal these days, but I'm still a little paranoid from when they didn't.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 52 insertions(+))
Terraform Beta: Diff ( 6 files changed, 296 insertions(+))
TF OiCS: Diff ( 8 files changed, 234 insertions(+))
Inspec: Diff ( 5 files changed, 44 insertions(+))

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@rileykarson rileykarson merged commit 47cb132 into GoogleCloudPlatform:master Apr 6, 2020
@drebes drebes deleted the hc-logs branch April 21, 2020 21:03
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
* hc-logging

* update health checking example to be beta only

* RegionHealthCheck Logging test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants