Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and update TestAccDialogflowAgent_update #3334

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Fix and update TestAccDialogflowAgent_update #3334

merged 2 commits into from
Apr 3, 2020

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Apr 3, 2020

Service account wasn't being created, failing the test.

Also minor updates to the test formatting.

Release Note Template for Downstream PRs (will be copied)

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 48 insertions(+), 38 deletions(-))
Terraform Beta: Diff ( 1 file changed, 48 insertions(+), 38 deletions(-))

@c2thorn c2thorn requested a review from megan07 April 3, 2020 00:17
@c2thorn c2thorn merged commit 1f6f623 into GoogleCloudPlatform:master Apr 3, 2020
@c2thorn c2thorn deleted the dialogflow-agent-test branch April 3, 2020 16:04
This was referenced Apr 3, 2020
Merged
Merged
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
@c2thorn
Fix and update TestAccDialogflowAgent_update (GoogleCloudPlatform#3334)
03a65ba 
* Fix TestAccDialogflowAgent_update

* Move to self hosted images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megan07 megan07 megan07 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@c2thorn @modular-magician @megan07 @googlebot