Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage bucket IAM diff suppress #3324

Merged
merged 1 commit into from
Mar 31, 2020
Merged

storage bucket IAM diff suppress #3324

merged 1 commit into from
Mar 31, 2020

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Mar 31, 2020

Fixes hashicorp/terraform-provider-google#5938

Release Note Template for Downstream PRs (will be copied)

storage: fixed an issue where `google_storage_bucket_iam_member` showed a diff for bucket self links

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 5 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 5 insertions(+), 1 deletion(-))

@c2thorn c2thorn requested a review from slevenick March 31, 2020 21:06
@c2thorn c2thorn merged commit 068a83b into GoogleCloudPlatform:master Mar 31, 2020
@c2thorn c2thorn deleted the storage-iam-diff-suppress branch March 31, 2020 22:14
This was referenced Mar 31, 2020
Merged
Merged
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
@c2thorn
storage bucket IAM diff suppress (GoogleCloudPlatform#3324)
e837341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slevenick slevenick slevenick approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

google_storage_bucket_iam_member shows diff for bucket self links
4 participants
@c2thorn @modular-magician @slevenick @googlebot