Virtual field for google_cloud_run_service revision names
#3306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisst
approved these changes
Mar 25, 2020
products/cloudrun/terraform.yaml
Outdated
| description: | | ||
| If set to `true`, the revision name (template.metadata.name) will be omitted and | ||
| autogenerated by Cloud Run. This cannot be set to `true` while `template.metadata.name` | ||
| is also set. |
There was a problem hiding this comment.
It might be good to clarify somewhere that if name isn't in the config and this is false it will still be managed server side for legacy support.
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 37 insertions(+), 2 deletions(-)) |
This was referenced Mar 26, 2020
Merged
nathkn
pushed a commit
to nathkn/magic-modules
that referenced
this pull request
May 18, 2020
…oudPlatform#3306) * Add `autogenerate_revision_name` virtual field to `google_cloud_run_service` * Add field to examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hashicorp/terraform-provider-google#5898
Release Note Template for Downstream PRs (will be copied)