Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage_bucket: explain what happens when multiple conditions are spe… #3304

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

rileykarson
Copy link
Member

Upstreams hashicorp/terraform-provider-google#5736

Release Note Template for Downstream PRs (will be copied)


@rileykarson rileykarson requested a review from slevenick March 25, 2020 21:58
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@rileykarson
Copy link
Member Author

No CLA is needed, changes are to a third_party dir not subject to the CLA.

@rileykarson rileykarson merged commit a5b8cec into GoogleCloudPlatform:master Mar 25, 2020
@rileykarson rileykarson deleted the scondition branch March 25, 2020 22:06
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants