Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vcr tests to gke handwritten #3293

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Add vcr tests to gke handwritten #3293

merged 2 commits into from
Mar 25, 2020

Conversation

slevenick
Copy link
Contributor

@slevenick slevenick commented Mar 24, 2020 •
edited
Loading

Will enable running these tests for GKE, hoping to turn up any issues with parallel/complex test runs via this. Will not cause any changes with current tests

Release Note Template for Downstream PRs (will be copied)

@slevenick slevenick requested a review from megan07 March 24, 2020 21:19
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 76 insertions(+), 76 deletions(-))
Terraform Beta: Diff ( 1 file changed, 108 insertions(+), 108 deletions(-))

@slevenick slevenick requested a review from emilymye March 24, 2020 21:42
megan07
megan07 approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@megan07 megan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 129 insertions(+), 130 deletions(-))
Terraform Beta: Diff ( 1 file changed, 184 insertions(+), 184 deletions(-))

@slevenick slevenick merged commit 43ef860 into GoogleCloudPlatform:master Mar 25, 2020
This was referenced Mar 25, 2020
Merged
Merged
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
@slevenick
Add vcr tests to gke handwritten (GoogleCloudPlatform#3293)
a8acb2a 
* Add vcr tests to gke handwritten

* Use new VCR random call in container tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megan07 megan07 megan07 approved these changes

@emilymye emilymye Awaiting requested review from emilymye

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slevenick @modular-magician @megan07 @googlebot