Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Authenticated Data AAD for Cloud KMS secrets #3271

Merged
merged 4 commits into from
Mar 24, 2020

Conversation

chrissng
Copy link
Contributor

@chrissng chrissng commented Mar 19, 2020

Allow setting Additional Authenticated Data AAD for Cloud KMS secrets (encryption and decryption)

Fixes hashicorp/terraform-provider-google#2961

Release Note Template for Downstream PRs (will be copied)

kms: Added new field "Additional Authenticated Data" for Cloud KMS data source `google_kms_secret`
kms: Added new field "Additional Authenticated Data" for Cloud KMS resource `google_kms_secret_ciphertext`

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@chrisst, please review this PR or find an appropriate assignee.

@chrissng chrissng changed the title Kms secret aad Additional Authenticated Data AAD for Cloud KMS secrets Mar 19, 2020
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 75 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 75 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 107 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 7 files changed, 107 insertions(+), 5 deletions(-))

@chrisst chrisst self-assigned this Mar 20, 2020
@chrissng
Copy link
Contributor Author

Hi @chrisst do you mind to review this PR? Thanks!

@chrisst
Copy link
Contributor

chrisst commented Mar 24, 2020

Was actually just running the tests locally as you posted :)

Copy link
Contributor

@chrisst chrisst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing locally and overall looks good, thanks!

@chrisst chrisst merged commit 54c8b06 into GoogleCloudPlatform:master Mar 24, 2020
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
…latform#3271)

* AAD for KMS secrets

* add test for decryption

* update datasource docs for google_kms_secret (decrypt)

* add test for encryption with aad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support AAD for google_kms_secret
4 participants