-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional Authenticated Data AAD for Cloud KMS secrets #3271
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @chrisst, please review this PR or find an appropriate assignee. |
Hi @chrisst do you mind to review this PR? Thanks! |
Was actually just running the tests locally as you posted :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing locally and overall looks good, thanks!
…latform#3271) * AAD for KMS secrets * add test for decryption * update datasource docs for google_kms_secret (decrypt) * add test for encryption with aad
Allow setting Additional Authenticated Data AAD for Cloud KMS secrets (encryption and decryption)
Fixes hashicorp/terraform-provider-google#2961
Release Note Template for Downstream PRs (will be copied)