Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow import of logging_metric in a non-default project. #3270

Merged

Conversation

nat-henderson
Copy link
Contributor

@nat-henderson nat-henderson commented Mar 18, 2020

Release Note Template for Downstream PRs (will be copied)

logging: Fixed import issue with `google_logging_metric` in a non-default project.

Fixes hashicorp/terraform-provider-google#5867.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 7 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 9 files changed, 9 insertions(+), 8 deletions(-))

@nat-henderson nat-henderson requested a review from c2thorn March 18, 2020 23:44
@@ -14,7 +14,7 @@
overrides: !ruby/object:Overrides::ResourceOverrides
Metric: !ruby/object:Overrides::Terraform::ResourceOverride
id_format: "{{name}}"
import_format: ["{{name}}"]
import_format: ["{{name}}", "{{project}} {{name}}"]
Copy link
Member

@c2thorn c2thorn Mar 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be {{project}}/{{name}}?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately no, {{name}} can contain slashes. :(

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 7 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 9 files changed, 9 insertions(+), 8 deletions(-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to import google logging metric using terraform
4 participants