Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google_compute_instance current_status to data source #3269

Merged
merged 6 commits into from
Mar 18, 2020
Merged

Add google_compute_instance current_status to data source #3269

merged 6 commits into from
Mar 18, 2020

Conversation

sebglon
Copy link
Contributor

@sebglon sebglon commented Mar 18, 2020

Release Note Template for Downstream PRs (will be copied)

compute: Added `current_status` field to `data.google_compute_instance`

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rambleraptor, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 2 insertions(+))
Terraform Beta: Diff ( 2 files changed, 2 insertions(+))

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 2 insertions(+))
Terraform Beta: Diff ( 2 files changed, 2 insertions(+))

2 similar comments
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 2 insertions(+))
Terraform Beta: Diff ( 2 files changed, 2 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 2 insertions(+))
Terraform Beta: Diff ( 2 files changed, 2 insertions(+))

@rileykarson rileykarson changed the title Add Compute status on data source Add google_compute_instance current_status to data source Mar 18, 2020
@rileykarson rileykarson merged commit a8ca6c9 into GoogleCloudPlatform:master Mar 18, 2020
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
…dPlatform#3269)

* Add current status on compute instance

* Add current_status on data compute_instance

* Add field on test

* Update resource_compute_instance.go

* Update resource_compute_instance.go

* clean

Co-authored-by: Sébastien GLON <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants