Add router resource #325
Add router resource #325
Conversation
|
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 89be6c2) have been included in your existing downstream PRs. |
| @@ -0,0 +1,216 @@ | |||
| package google | |||
There was a problem hiding this comment.
In Puppet/Chef/Ansible, we have the products/compute/files folder to hold files exclusive to compute.
I feel like Terraform should move towards that model as well for consistency, unless this test template will be used for other things too.
There was a problem hiding this comment.
Yeah, we've talked a little bit about this- on one hand, yes. On the other hand, all the other go code that we have for terraform is inside the templates folder (a lot of it, though not actually a template, is shared), and it feels weird to stick this somewhere totally far away in the code base just because of that. This will be a good thing to revisit when we go through and scrutinize the names of things and stuff.
| A reference to the network to which this router belongs. | ||
| required: true | ||
| input: true | ||
| # TODO(danawillow): Figure out the story for interfaces/bgpPeers. Right |
There was a problem hiding this comment.
That's a great model and I'd love to have it in these other providers. Another of the places that MagicModules can be a better cleaner declarative version of the GCP APIs.
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 802b0aa) have been included in your existing downstream PRs. |
Tracked submodules are build/puppet/compute build/puppet/sql build/puppet/storage build/puppet/container build/puppet/dns build/puppet/pubsub build/puppet/resourcemanager build/chef/compute build/chef/sql build/chef/storage build/chef/container build/chef/dns build/terraform build/ansible.
Fixes #319
I wouldn't mind some feedback on the TODO I have in api.yaml about peer and interface.
[all]
Add router resource
[terraform]
Autogenerate router resource. Also adds update support and a few new fields.
[puppet]
[puppet-compute]
[puppet-sql]
[puppet-storage]
[chef]
[chef-compute]
[chef-sql]
[chef-storage]
[ansible]