Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tier ignore_read #3223

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Mar 5, 2020

Fixes hashicorp/terraform-provider-google#5775

The tier field is not consistent enough in the backend to be useful. Marking it as ignore_read, and removing the attempt at polling.

Release Note Template for Downstream PRs (will be copied)

dialogflow: Changed `google_dialogflow_agent` to not read `tier` status

@c2thorn c2thorn requested a review from emilymye March 5, 2020 18:10
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 7 insertions(+), 73 deletions(-))
Terraform Beta: Diff ( 4 files changed, 7 insertions(+), 73 deletions(-))

@c2thorn c2thorn merged commit bfc75b9 into GoogleCloudPlatform:master Mar 5, 2020
@c2thorn c2thorn deleted the dialogflow branch March 5, 2020 19:59
@c2thorn
Copy link
Member Author

c2thorn commented Mar 9, 2020

nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deflake TestAccDialogflowAgent_update
4 participants