Ansible - Regional SSL Certs + Health Check

[rambleraptor]

Regional SSL Certs + Health Checks

Release Note Template for Downstream PRs (will be copied)

`google_compute_region_ssl_certificate`

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 1007 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 25 insertions(+), 9 deletions(-))
Ansible: Diff ( 15 files changed, 2845 insertions(+))
TF Conversion: Diff ( 1 file changed, 115 insertions(+))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 1007 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 25 insertions(+), 9 deletions(-))
Ansible: Diff ( 15 files changed, 2845 insertions(+))
TF Conversion: Diff ( 1 file changed, 115 insertions(+))

[slevenick]

Since this moves the resource from beta -> GA in Terraform you will need to go through all of the examples defined for this resource in the terraform.yaml and remove instances of provider = google-beta,

For instance, here: https://github.com/GoogleCloudPlatform/magic-modules/blob/master/templates/terraform/examples/region_ssl_certificate_basic.tf.erb

Also add a note to the release notes block about the resource going from beta -> GA. Guidelines are here: https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md

This would be a new-resource I believe

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 1001 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 25 insertions(+), 15 deletions(-))
Ansible: Diff ( 10 files changed, 1966 insertions(+))
TF Conversion: Diff ( 1 file changed, 115 insertions(+))
TF OiCS: Diff ( 3 files changed, 3 deletions(-))

[rambleraptor]

@slevenick - changes made!

[slevenick]

Ah, you have to remove all of the lines that say provider = google-beta in those files. The GA provider doesn't have the beta provider during testing, so it cannot use any resources that using the beta provider

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 993 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 25 insertions(+), 23 deletions(-))
Ansible: Diff ( 10 files changed, 1966 insertions(+))
TF Conversion: Diff ( 1 file changed, 115 insertions(+))
TF OiCS: Diff ( 3 files changed, 7 deletions(-))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 901 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 18 insertions(+), 12 deletions(-))
Ansible: Diff ( 10 files changed, 1966 insertions(+))
TF Conversion: Diff ( 1 file changed, 115 insertions(+))
TF OiCS: Diff ( 2 files changed, 2 deletions(-))