Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project_service update to read/acquire a service on create #3182

Merged
merged 2 commits into from
Mar 2, 2020

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Feb 27, 2020

Instead of trying to enable the API every time on Create, I added a read to check if the API was already enabled first.

Release Note Template for Downstream PRs (will be copied)

`google_project_service` will no longer attempt to enable a service that is already enabled.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 18 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 1 file changed, 18 insertions(+), 4 deletions(-))

@c2thorn c2thorn requested review from danawillow and removed request for chrisst March 2, 2020 20:39
Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a behavior change, can you add a release note? I think enhancement will be good. It would also be good to have this behavior documented in the project_service docs just to be explicit that it's intentional.

This doesn't have a GH issue open for it, does it?

@c2thorn
Copy link
Member Author

c2thorn commented Mar 2, 2020

Updated! The docs already had a little blurb that was relevant, so I just modified it to say "verify" instead of "re-enable" an already enabled service.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 19 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 2 files changed, 19 insertions(+), 5 deletions(-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants