Google project precheck #3145
Merged
Google project precheck #3145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danawillow
approved these changes
Feb 18, 2020
| Permissions: []string{perm}, | ||
| } | ||
| resp, err := config.clientBilling.BillingAccounts.TestIamPermissions(ba, req).Do() | ||
| if err != nil { |
There was a problem hiding this comment.
Was there a consensus on whether this request failing should actually fail the apply?
There was a problem hiding this comment.
I changed my mind and decided it's fine. I'd love to make this a check for the correct API being enabled but I'm not sure it's possible at this point. I added something to that effect in hashicorp/terraform-provider-google#5671 (comment)
This was referenced Feb 19, 2020
nathkn
pushed a commit
to nathkn/magic-modules
that referenced
this pull request
May 18, 2020
* project: check for billing account perms as pre-requisite * outdent * typo * rm type from error message * simplify perms check * simplify bool check * simplify bool check Co-authored-by: Umair Idris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes hashicorp/terraform-provider-google#5671 as it's the upstream pr.
fixes hashicorp/terraform-provider-google#5222
references terraform-google-modules/terraform-google-project-factory#373
Release Note Template for Downstream PRs (will be copied)