IAP brand & client

[drebes]

Fixes hashicorp/terraform-provider-google#1287

Release Note Template for Downstream PRs (will be copied)

`google_iap_brand`

`google_iap_client`

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 923 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 923 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 118 insertions(+))

[drebes]

This acceptance test won't succeed unless the specified group is owned by the service account running the test.

[drebes]

Fixes hashicorp/terraform-provider-google#1287

[danawillow]

drive-by: the "fixes" statement won't automatically close the issue if it's in a comment- it needs to be in the PR description or a commit (I usually do the PR description like in #3063)

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 938 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 938 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 118 insertions(+))

[pvillard31]

Sorry for the comment/question, feel free to redirect me to the right place if I should ask this somewhere else.

If I correctly understand this PR, its purpose is to provide a way to create the "APIs & Services / OAuth consent screen". However, I do not see how to specify information such as authorised domains, homepage link, etc. Am I missing something?

Also I see that client ID and client secret are made available but how to specify "Authorised JavaScript origins" and "Authorised redirect URIs". Is it out of scope of this PR?

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 939 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 939 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 118 insertions(+))

[slevenick]

#3162 Should fix the issues I ran into around the beta provider and base path names.

I'm happy with the current implementation, I would just like to get integration tests working for this so that we can run them via CI.

I think all we need is to add a new environment variable to provider_test.go that will represent the organization domain. Then we can depend on support@{org-domain} existing and the service account running the tests to be an admin for that group email (I'll go set this up manually)

[slevenick]

Hey @drebes do you think you will have a chance to add support for those tests via the environment variable sometime soon?

I can also pick this up and add the changes to your branch, just let me know if you want me to do that

[drebes]

Sure I can add them (sorry, I didn't understand "all we need is to add a new environment variable" to mean me, but I can look into it.)

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 950 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 10 files changed, 950 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 118 insertions(+))

[drebes]

Added the configurable domain for the acceptance tests.

You need to create a group "support@<acceptance_test_domain>" and make the acceptance test service account an owner of such group, and then set GOOGLE_ORG_DOMAIN as <acceptance_test_domain>.

[slevenick]

Awesome, looks good! I got it to pass locally, so I'll modify the CI test org to add this. Can you rebase this from master, looks like a couple things are out of sync

[drebes]

There you go. Rebased with the collapsed sidebar changes that were causing the conflict. Which also made me realized that I hadn't updated the sidebar for iap_client since I had updated it to the short form. Should be good now.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 950 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 10 files changed, 950 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 118 insertions(+))

[slevenick]

Thanks for the additions!