Terraform Data Source to get DNSKEY records of DNSSEC-signed managed zones #3117

chrissng · 2020-02-12T15:28:05Z

Terraform Data Source to get DNSKEY records of DNSSEC-signed managed zones.

Fixes: hashicorp/terraform-provider-google#4802

Release Note Template for Downstream PRs (will be copied)

google_dns_keys

Merge from upstream

modular-magician · 2020-02-12T15:32:08Z

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

modular-magician · 2020-02-12T15:33:59Z

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@SirGitsalot, please review this PR or find an appropriate assignee.

modular-magician · 2020-02-12T15:34:31Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 347 insertions(+))
Terraform Beta: Diff ( 5 files changed, 347 insertions(+))
Ansible: Diff ( 2 files changed, 2 insertions(+), 3 deletions(-))

Inspec: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

modular-magician · 2020-02-12T15:36:56Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 347 insertions(+))
Terraform Beta: Diff ( 5 files changed, 347 insertions(+))
Ansible: Diff ( 2 files changed, 2 insertions(+), 3 deletions(-))

Inspec: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

modular-magician · 2020-02-12T15:44:38Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 347 insertions(+))
Terraform Beta: Diff ( 5 files changed, 347 insertions(+))
Ansible: Diff ( 2 files changed, 2 insertions(+), 3 deletions(-))

Inspec: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

modular-magician · 2020-02-12T15:46:52Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 347 insertions(+))
Terraform Beta: Diff ( 5 files changed, 347 insertions(+))
Ansible: Diff ( 2 files changed, 2 insertions(+), 3 deletions(-))

Inspec: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

modular-magician · 2020-02-13T02:45:57Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 364 insertions(+))
Terraform Beta: Diff ( 5 files changed, 364 insertions(+))
Ansible: Diff ( 2 files changed, 2 insertions(+), 3 deletions(-))

Inspec: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

slevenick

Looks great! Just a couple minor issues and I'll be able to merge this in

third_party/terraform/website/docs/d/datasource_dns_key.html.markdown

slevenick · 2020-02-13T20:34:50Z

third_party/terraform/utils/provider.go.erb

@@ -181,6 +181,7 @@ func Provider() terraform.ResourceProvider {
 			"google_container_engine_versions":                 dataSourceGoogleContainerEngineVersions(),
 			"google_container_registry_image":                  dataSourceGoogleContainerImage(),
 			"google_container_registry_repository":             dataSourceGoogleContainerRepo(),
+			"google_dns_key":                                   dataSourceDNSKey(),


I think it makes sense for this resource to be named google_dns_keys instead. It returns a collection of keys rather than an individual key

…arkdown Co-Authored-By: Sam Levenick <[email protected]>

modular-magician · 2020-02-14T02:15:33Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 364 insertions(+))
Terraform Beta: Diff ( 5 files changed, 364 insertions(+))
Ansible: Diff ( 2 files changed, 2 insertions(+), 3 deletions(-))

Inspec: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

…les into get-dnssec-key-pairs

modular-magician · 2020-02-14T03:01:58Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 381 insertions(+))
Terraform Beta: Diff ( 5 files changed, 381 insertions(+))
Ansible: Diff ( 2 files changed, 2 insertions(+), 3 deletions(-))

Inspec: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

modular-magician · 2020-02-14T03:11:04Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 385 insertions(+))
Terraform Beta: Diff ( 5 files changed, 385 insertions(+))
Ansible: Diff ( 2 files changed, 2 insertions(+), 3 deletions(-))

Inspec: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

modular-magician · 2020-02-14T05:18:24Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 385 insertions(+))
Terraform Beta: Diff ( 5 files changed, 385 insertions(+))
Ansible: Diff ( 2 files changed, 2 insertions(+), 3 deletions(-))

Inspec: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

modular-magician · 2020-02-14T05:30:22Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 385 insertions(+))
Terraform Beta: Diff ( 5 files changed, 385 insertions(+))
Ansible: Diff ( 2 files changed, 2 insertions(+), 3 deletions(-))

Inspec: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

slevenick

Looks good, thanks for the contribution!

…zones (GoogleCloudPlatform#3117) * DNSSEC Keys * update schema * Define as a data source * add into data sources map * remove unused import * add tests * No fill dns keys of zone is not dnssec enabled * add docs * add ds record to ksk * fix string templating * improve doc description * improve ds record generation * Update third_party/terraform/website/docs/d/datasource_dns_key.html.markdown Co-Authored-By: Sam Levenick <[email protected]> * rename data source in plural * rename file, add comment on maps * rename doc file Co-authored-by: Sam Levenick <[email protected]>

chrissng added 9 commits February 10, 2020 14:49

Merge pull request #1 from GoogleCloudPlatform/master

0e23520

Merge from upstream

DNSSEC Keys

d821416

update schema

9423899

Define as a data source

4efd907

add into data sources map

df6b998

remove unused import

f265f63

add tests

ace5d32

No fill dns keys of zone is not dnssec enabled

d1a1452

add docs

37296b1

googlebot added the cla: yes label Feb 12, 2020

add ds record to ksk

53cfac9

modular-magician added the community label Feb 12, 2020

fix string templating

623d5b6

chrissng marked this pull request as ready for review February 12, 2020 15:37

improve doc description

7cc51a2

improve ds record generation

6def1c0

slevenick requested changes Feb 13, 2020

View reviewed changes

Update third_party/terraform/website/docs/d/datasource_dns_key.html.m…

97abc5a

…arkdown Co-Authored-By: Sam Levenick <[email protected]>

chrissng added 2 commits February 14, 2020 10:54

rename data source in plural

34a5433

Merge branch 'get-dnssec-key-pairs' of github.com:chrissng/magic-modu…

03edd76

…les into get-dnssec-key-pairs

rename file, add comment on maps

cc1770f

rename doc file

0291d90

chrissng requested a review from slevenick February 18, 2020 01:14

slevenick approved these changes Feb 18, 2020

View reviewed changes

slevenick merged commit 48bf912 into GoogleCloudPlatform:master Feb 18, 2020

This was referenced Feb 18, 2020

Terraform Data Source to get DNSKEY records of DNSSEC-signed managed zones hashicorp/terraform-provider-google#5703

Merged

Terraform Data Source to get DNSKEY records of DNSSEC-signed managed zones hashicorp/terraform-provider-google-beta#1768

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Terraform Data Source to get DNSKEY records of DNSSEC-signed managed zones #3117

Terraform Data Source to get DNSKEY records of DNSSEC-signed managed zones #3117

chrissng commented Feb 12, 2020 •

edited by slevenick

Loading

modular-magician commented Feb 12, 2020

modular-magician commented Feb 12, 2020

modular-magician commented Feb 12, 2020

modular-magician commented Feb 12, 2020

modular-magician commented Feb 12, 2020

modular-magician commented Feb 12, 2020

modular-magician commented Feb 13, 2020

slevenick left a comment

slevenick Feb 13, 2020

chrissng Feb 14, 2020

modular-magician commented Feb 14, 2020

modular-magician commented Feb 14, 2020

modular-magician commented Feb 14, 2020

modular-magician commented Feb 14, 2020

modular-magician commented Feb 14, 2020

slevenick left a comment

Terraform Data Source to get DNSKEY records of DNSSEC-signed managed zones #3117

Terraform Data Source to get DNSKEY records of DNSSEC-signed managed zones #3117

Conversation

chrissng commented Feb 12, 2020 • edited by slevenick Loading

modular-magician commented Feb 12, 2020

modular-magician commented Feb 12, 2020

modular-magician commented Feb 12, 2020

Diff report:

modular-magician commented Feb 12, 2020

Diff report:

modular-magician commented Feb 12, 2020

Diff report:

modular-magician commented Feb 12, 2020

Diff report:

modular-magician commented Feb 13, 2020

Diff report:

slevenick left a comment

Choose a reason for hiding this comment

slevenick Feb 13, 2020

Choose a reason for hiding this comment

chrissng Feb 14, 2020

Choose a reason for hiding this comment

modular-magician commented Feb 14, 2020

Diff report:

modular-magician commented Feb 14, 2020

Diff report:

modular-magician commented Feb 14, 2020

Diff report:

modular-magician commented Feb 14, 2020

Diff report:

modular-magician commented Feb 14, 2020

Diff report:

slevenick left a comment

Choose a reason for hiding this comment

chrissng commented Feb 12, 2020 •

edited by slevenick

Loading