Adds storage_hmac_key_resource #3084

geojaz · 2020-02-06T02:12:20Z

I'm working to get the hmac key resource active in the terraform provider.

~~Note: this code creates the key, but isn't printing the secret right now. I could use a second pair of eyes on this @rileykarson as this is my first magic-modules contrib. Thanks!~~
Note: At this point I've (manually) cruded and used the key that it returned. Thanks to the help of riley, I think we're pretty much just fine-tuning downstream outputs.

`google_storage_hmac_key`

modular-magician · 2020-02-06T02:15:38Z

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@SirGitsalot, please review this PR or find an appropriate assignee.

rileykarson

I can't see anything out of place. Mind adding an exclude: true in inspec.yaml + ansible.yaml for this resource? Our system gets tripped up sometimes with new resources in existing products and they cause generation to fail.

rileykarson

Ah, spotted it- the secret is only returned post-create. Commented with more context, and added a suggestion for metadata.

products/storage/api.yaml

geojaz · 2020-02-07T03:54:34Z

@rileykarson Thanks so much for the feedback and the hints!
Now it seems to be working as expected. PTAL, and I'll be happy to continue to consider any further suggestions.

modular-magician · 2020-02-07T03:56:25Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 603 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 4 files changed, 603 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 120 insertions(+))

rileykarson

Downstream generally looks good, I'd like to verify that it's working with tests. I've got a handful of wording changes / typo fixes, but looking great.

products/storage/terraform.yaml

templates/terraform/post_create/hmac_secret.go.erb

products/storage/terraform.yaml

products/storage/api.yaml

products/storage/terraform.yaml

modular-magician · 2020-02-08T16:42:36Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 603 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 4 files changed, 603 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 120 insertions(+))

modular-magician · 2020-02-08T16:48:01Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 603 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 4 files changed, 603 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 120 insertions(+))

modular-magician · 2020-02-10T17:23:16Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 702 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 702 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 120 insertions(+))
TF OiCS: Diff ( 1 file changed, 120 insertions(+))

modular-magician · 2020-02-10T19:21:43Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 775 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 775 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 120 insertions(+))
TF OiCS: Diff ( 1 file changed, 120 insertions(+))

modular-magician · 2020-02-10T19:23:32Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 774 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 774 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 120 insertions(+))
TF OiCS: Diff ( 1 file changed, 120 insertions(+))

modular-magician · 2020-02-10T19:39:49Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 774 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 774 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 120 insertions(+))
TF OiCS: Diff ( 1 file changed, 120 insertions(+))

modular-magician · 2020-02-10T19:42:33Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 773 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 773 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 120 insertions(+))
TF OiCS: Diff ( 1 file changed, 120 insertions(+))

rileykarson

Added a few comments for now, going to run tests to verify my assumptions and see if there's anything I missed.

third_party/terraform/tests/resource_storage_hmac_key_test.go

products/storage/api.yaml

products/storage/terraform.yaml

third_party/terraform/tests/resource_storage_hmac_key_test.go

rileykarson

Here's a handful of formatting / syntax error I ran into while running tests (sorry if they conflict with changes you've since made!)

third_party/terraform/tests/resource_storage_hmac_key_test.go

templates/terraform/post_create/hmac_secret.go.erb

products/storage/api.yaml

modular-magician · 2020-02-10T21:06:33Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 786 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 786 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 120 insertions(+))
TF OiCS: Diff ( 1 file changed, 120 insertions(+))

modular-magician · 2020-02-10T21:19:00Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 783 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 783 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 120 insertions(+))
TF OiCS: Diff ( 1 file changed, 120 insertions(+))

modular-magician · 2020-02-10T21:49:54Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 782 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 782 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 120 insertions(+))
TF OiCS: Diff ( 1 file changed, 120 insertions(+))

third_party/terraform/tests/resource_storage_hmac_key_test.go

modular-magician · 2020-02-10T22:34:28Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 764 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 764 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 120 insertions(+))
TF OiCS: Diff ( 1 file changed, 120 insertions(+))

products/storage/terraform.yaml

products/storage/api.yaml

third_party/terraform/tests/resource_storage_hmac_key_test.go

products/storage/api.yaml

Co-Authored-By: Riley Karson <[email protected]>

…improves test

rileykarson · 2020-02-13T01:22:36Z

@emilymye: I picked up this PR to get it over the finish line, as the API didn't map to MM all that well. Lots of handholding / custom code to get it to behave correctly. Adding you as reviewer because I made substantial enough changes that I should get a new set of 👀 on it.

modular-magician · 2020-02-13T01:24:43Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 642 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 642 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 64 insertions(+))
TF OiCS: Diff ( 1 file changed, 64 insertions(+))

modular-magician · 2020-02-13T01:28:23Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 642 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 642 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 64 insertions(+))
TF OiCS: Diff ( 1 file changed, 64 insertions(+))

… anyways

modular-magician · 2020-02-13T02:15:43Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 636 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 636 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 64 insertions(+))
TF OiCS: Diff ( 1 file changed, 64 insertions(+))

products/storage/terraform.yaml

templates/terraform/pre_delete/storage_hmac_key.go.erb

* Adds hmac key * Fixes up hmacKey resource properties in terraform * Update products/storage/terraform.yaml Co-Authored-By: Riley Karson <[email protected]> * Update products/storage/api.yaml Co-Authored-By: Riley Karson <[email protected]> * Adds an example, website links, and several fixes from review * Adds test and fixes hmac_key id * tweaking hmac_key example * Update third_party/terraform/tests/resource_storage_hmac_key_test.go Co-Authored-By: Riley Karson <[email protected]> * Update products/storage/api.yaml Co-Authored-By: Riley Karson <[email protected]> * Update third_party/terraform/tests/resource_storage_hmac_key_test.go Co-Authored-By: Riley Karson <[email protected]> * hmac_key: adds doc warning about secrets, fixes yaml formatting, and improves test * More fixes for review * Fixing gofmt * fix resource name * more iteration * More fixes * RM unused var in hmac_key_test * hmac_key: Pre-delete and more fixes * Fixing wrong assumptions * Edits to support read schema * Get tests passing, handle deleted items properly * Sidebar - to _ * Remove the update encoder because the docs are wrong on update format anyways Co-authored-by: Riley Karson <[email protected]>

googlebot added the cla: yes label Feb 6, 2020

modular-magician added the community label Feb 6, 2020

rileykarson reviewed Feb 6, 2020

View reviewed changes

products/storage/api.yaml Show resolved Hide resolved

products/storage/api.yaml Outdated Show resolved Hide resolved

geojaz changed the title ~~Adds storage_hmac_key_resource [wip]~~ Adds storage_hmac_key_resourc Feb 7, 2020

geojaz changed the title ~~Adds storage_hmac_key_resourc~~ Adds storage_hmac_key_resource Feb 7, 2020

rileykarson reviewed Feb 7, 2020

View reviewed changes

geojaz force-pushed the hmac_key branch from 23b0e7c to c119173 Compare February 10, 2020 19:17

geojaz force-pushed the hmac_key branch from ca5e6e3 to b99d593 Compare February 10, 2020 19:36

rileykarson reviewed Feb 10, 2020

View reviewed changes

products/storage/api.yaml Outdated Show resolved Hide resolved

rileykarson reviewed Feb 10, 2020

View reviewed changes

third_party/terraform/tests/resource_storage_hmac_key_test.go Outdated Show resolved Hide resolved

rileykarson reviewed Feb 10, 2020

View reviewed changes

products/storage/terraform.yaml Show resolved Hide resolved

products/storage/api.yaml Outdated Show resolved Hide resolved

geojaz commented Feb 11, 2020

View reviewed changes

third_party/terraform/tests/resource_storage_hmac_key_test.go Outdated Show resolved Hide resolved

rileykarson reviewed Feb 11, 2020

View reviewed changes

products/storage/api.yaml Outdated Show resolved Hide resolved

geojaz and others added 16 commits February 12, 2020 10:19

Adds test and fixes hmac_key id

f54b5cb

tweaking hmac_key example

cc28775

Update third_party/terraform/tests/resource_storage_hmac_key_test.go

bd1d42d

Co-Authored-By: Riley Karson <[email protected]>

Update products/storage/api.yaml

bee0e27

Co-Authored-By: Riley Karson <[email protected]>

Update third_party/terraform/tests/resource_storage_hmac_key_test.go

b786218

Co-Authored-By: Riley Karson <[email protected]>

hmac_key: adds doc warning about secrets, fixes yaml formatting, and …

76daab9

…improves test

More fixes for review

9fc366f

Fixing gofmt

cb69003

fix resource name

4406dbb

more iteration

d8e3ebf

More fixes

a9c0b81

RM unused var in hmac_key_test

ce60da2

hmac_key: Pre-delete and more fixes

b6e13a3

Fixing wrong assumptions

61abe9a

Edits to support read schema

8059dfe

Get tests passing, handle deleted items properly

5a54661

rileykarson force-pushed the hmac_key branch from 4c66fb3 to 5a54661 Compare February 13, 2020 01:20

rileykarson requested a review from emilymye February 13, 2020 01:21

Sidebar - to _

6bd8143

Remove the update encoder because the docs are wrong on update format…

912ee8d

… anyways

emilymye approved these changes Feb 13, 2020

View reviewed changes

products/storage/terraform.yaml Show resolved Hide resolved

templates/terraform/pre_delete/storage_hmac_key.go.erb Show resolved Hide resolved

templates/terraform/pre_delete/storage_hmac_key.go.erb Show resolved Hide resolved

rileykarson merged commit 6bf6455 into GoogleCloudPlatform:master Feb 13, 2020

This was referenced Feb 13, 2020

Adds storage_hmac_key_resource hashicorp/terraform-provider-google#5679

Merged

Adds storage_hmac_key_resource hashicorp/terraform-provider-google-beta#1765

Merged

geojaz deleted the hmac_key branch February 25, 2020 17:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds storage_hmac_key_resource #3084

Adds storage_hmac_key_resource #3084

geojaz commented Feb 6, 2020 •

edited

Loading

modular-magician commented Feb 6, 2020

rileykarson left a comment •

edited

Loading

rileykarson left a comment

geojaz commented Feb 7, 2020

modular-magician commented Feb 7, 2020

rileykarson left a comment

modular-magician commented Feb 8, 2020

modular-magician commented Feb 8, 2020

modular-magician commented Feb 10, 2020

modular-magician commented Feb 10, 2020

modular-magician commented Feb 10, 2020

modular-magician commented Feb 10, 2020

modular-magician commented Feb 10, 2020

rileykarson left a comment

rileykarson left a comment

modular-magician commented Feb 10, 2020

modular-magician commented Feb 10, 2020

modular-magician commented Feb 10, 2020

modular-magician commented Feb 10, 2020

rileykarson commented Feb 13, 2020

modular-magician commented Feb 13, 2020

modular-magician commented Feb 13, 2020

modular-magician commented Feb 13, 2020

Adds storage_hmac_key_resource #3084

Adds storage_hmac_key_resource #3084

Conversation

geojaz commented Feb 6, 2020 • edited Loading

modular-magician commented Feb 6, 2020

rileykarson left a comment • edited Loading

Choose a reason for hiding this comment

rileykarson left a comment

Choose a reason for hiding this comment

geojaz commented Feb 7, 2020

modular-magician commented Feb 7, 2020

Diff report:

rileykarson left a comment

Choose a reason for hiding this comment

modular-magician commented Feb 8, 2020

Diff report:

modular-magician commented Feb 8, 2020

Diff report:

modular-magician commented Feb 10, 2020

Diff report:

modular-magician commented Feb 10, 2020

Diff report:

modular-magician commented Feb 10, 2020

Diff report:

modular-magician commented Feb 10, 2020

Diff report:

modular-magician commented Feb 10, 2020

Diff report:

rileykarson left a comment

Choose a reason for hiding this comment

rileykarson left a comment

Choose a reason for hiding this comment

modular-magician commented Feb 10, 2020

Diff report:

modular-magician commented Feb 10, 2020

Diff report:

modular-magician commented Feb 10, 2020

Diff report:

modular-magician commented Feb 10, 2020

Diff report:

rileykarson commented Feb 13, 2020

modular-magician commented Feb 13, 2020

Diff report:

modular-magician commented Feb 13, 2020

Diff report:

modular-magician commented Feb 13, 2020

Diff report:

geojaz commented Feb 6, 2020 •

edited

Loading

rileykarson left a comment •

edited

Loading