Add support for IAP in google_app_engine_application resource #3058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisst
reviewed
Jan 31, 2020
| Providers: testAccProviders, | ||
| Steps: []resource.TestStep{ | ||
| { | ||
| Config: testAccAppEngineApplication_withIAP(pid, org), |
There was a problem hiding this comment.
Probably worth adding an update step here.
chrisst
approved these changes
Jan 31, 2020
This was referenced Jan 31, 2020
|
Did documentation get omitted or am I missing it? |
|
@preston-hf looks like i missed adding docs for this! good catch, thank you! I've created an issue to track this hashicorp/terraform-provider-google#6184 |
nathkn
pushed a commit
to nathkn/magic-modules
that referenced
this pull request
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hashicorp/terraform-provider-google#3065
Release Note Template for Downstream PRs (will be copied)