-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VPC serverless access update version from beta to GA #3053
VPC serverless access update version from beta to GA #3053
Conversation
vpc access connector is now GA https://cloud.google.com/functions/docs/release-notes#December_11_2019
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the versions
block in products/vpcaccess/api.yaml to add a ga version? That should be all that's necessary to get this PR to build.
Also the title of this PR is much scarier than its contents 😛 mind updating it to be a bit more descriptive of what's actually happening?
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs. Thanks for your contribution! A human will be with you soon. @rileykarson, please review this PR or find an appropriate assignee. |
products/vpcaccess/api.yaml
Outdated
@@ -18,6 +18,9 @@ versions: | |||
- !ruby/object:Api::Product::Version | |||
name: beta | |||
base_url: https://vpcaccess.googleapis.com/v1beta1/ | |||
- !ruby/object:Api::Product::Version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll also need to remove the line that says min_version: beta
in the resource itself.
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 7 files changed, 810 insertions(+), 2 deletions(-)) |
@@ -3,7 +3,6 @@ provider "google-beta" { | |||
|
|||
resource "google_vpc_access_connector" "connector" { | |||
name = "<%= ctx[:vars]['name'] %>" | |||
provider = google-beta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also remove the provider block on line 1?
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 7 files changed, 804 insertions(+), 2 deletions(-)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @watchinharrison!
…form#3053) * remove beta provider vpc access connector is now GA https://cloud.google.com/functions/docs/release-notes#December_11_2019 * updated versions for VPC serverless acess * add back beta version * remove beta references in resource * remove google-beta provider from example
vpc access connector is now GA
https://cloud.google.com/functions/docs/release-notes#December_11_2019
Release Note Template for Downstream PRs (will be copied)