Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 2955 as it broke tests. #3008

Merged
merged 2 commits into from
Jan 22, 2020
Merged

Revert 2955 as it broke tests. #3008

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac37418
Rever 2955 as it broke tests.
paddycarver Jan 22, 2020
a4f76c6
Update tracked submodules -> HEAD on Wed Jan 22 21:59:22 UTC 2020
modular-magician Jan 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions third_party/terraform/resources/resource_storage_bucket_acl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,6 @@ func resourceStorageRoleEntityCustomizeDiff(diff *schema.ResourceDiff, meta inte
conf := map[string]struct{}{}
for i := 0; i < count; i++ {
old, new := diff.GetChange(fmt.Sprintf("role_entity.%d", i))

// project-owners- is explicitly stripped from the roles that this
// resource will delete
if strings.Contains(old.(string), "OWNER:project-owners-") {
continue
}

state[old.(string)] = struct{}{}
conf[new.(string)] = struct{}{}
}
Expand Down